Skip to content

Conversation

@rickie
Copy link
Member

@rickie rickie commented Nov 12, 2025

No description provided.

@rickie
Copy link
Member Author

rickie commented Nov 12, 2025

/integration-test

snapshot.dump(output);

- assertThat(output.toString()).isEqualTo(String.format("1%n2%n3%n4%n5%n"));
+ assertThat(output).hasToString(String.format("1%n2%n3%n4%n5%n"));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is interesting 🤔, this doesn't do anything right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does do something: it replaces %n with System.lineSeparator().

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member

Build failed. @rickie could it be that you ran --sync with JDK 25? I think rerunning with JDK 21 will fix the metrics tests.

@rickie
Copy link
Member Author

rickie commented Nov 12, 2025

Yeah I'm checking right now :)

@rickie
Copy link
Member Author

rickie commented Nov 12, 2025

It seems I was using 21 🤔.

@rickie
Copy link
Member Author

rickie commented Nov 12, 2025

/integration-test

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

@rickie
Copy link
Member Author

rickie commented Nov 12, 2025

Build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants