Skip to content

Conversation

Stephan202
Copy link
Member

Resolves an issue found while testing Error Prone Support against Checkstyle (currently testing on this branch).

Suggested commit message:

Improve `IdentityConversion` check (#407)

If the result of an explicit boxing operation is immediately
dereferenced, then the explicit conversion operation is not redundant.

@Stephan202 Stephan202 added this to the 0.7.0 milestone Dec 11, 2022
@Stephan202 Stephan202 requested a review from rickie December 11, 2022 06:05
@github-actions
Copy link

Looks good. All 6 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.IdentityConversion 0 6

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions
Copy link

Looks good. All 6 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.IdentityConversion 0 6

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the sschroevers/IdentityConversion-improvements branch from a69a7b3 to ce3dc14 Compare December 19, 2022 15:03
@github-actions
Copy link

Looks good. All 6 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.IdentityConversion 0 6

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty fun edge case. Fix looks good to me.

If the result of an explicit boxing operation is immediately
dereferenced, then the explicit conversion operation is not redundant.
@rickie rickie force-pushed the sschroevers/IdentityConversion-improvements branch from ce3dc14 to a347980 Compare December 21, 2022 08:37
@rickie rickie added the bug fix label Dec 21, 2022
@rickie
Copy link
Member

rickie commented Dec 21, 2022

Hmm, is this an improvement or a bug fix?

@github-actions
Copy link

Looks good. All 6 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.IdentityConversion 0 6

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

Stephan202 commented Dec 21, 2022

  • Label-wise: bug fix 👍
  • Suggested commit message-wise: would leave as-is.

@rickie
Copy link
Member

rickie commented Dec 21, 2022

Ah yes I only meant label-wise 😄. Nice.

@rickie rickie merged commit 5665470 into master Dec 21, 2022
@rickie rickie deleted the sschroevers/IdentityConversion-improvements branch December 21, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants