Skip to content

Upgrade maven-enforcer-plugin 3.1.0 -> 3.2.1 #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2023
Merged

Upgrade maven-enforcer-plugin 3.1.0 -> 3.2.1 #487

merged 3 commits into from
Feb 4, 2023

Conversation

Picnic-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
org.apache.maven.plugins:maven-enforcer-plugin build minor 3.1.0 -> 3.2.1
  • If you want to rebase/retry this PR, check this box

@Picnic-Bot
Copy link
Contributor Author

Suggested commit message:

Upgrade maven-enforcer-plugin 3.1.0 -> 3.2.1

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

2 similar comments
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Picnic-Bot Picnic-Bot force-pushed the renovate/org.apache.maven.plugins-maven-enforcer-plugin-3.x branch from 44eb1e9 to 2352580 Compare February 3, 2023 02:01
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

3 similar comments
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Picnic-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@Stephan202 Stephan202 force-pushed the renovate/org.apache.maven.plugins-maven-enforcer-plugin-3.x branch from f1673a6 to 238f3e0 Compare February 4, 2023 07:56
@Stephan202 Stephan202 added this to the 0.9.0 milestone Feb 4, 2023
Stephan202
Stephan202 approved these changes Feb 4, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now enable other checks, but will do that in a separate PR.

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie
Copy link
Member

rickie commented Feb 4, 2023 •
edited by Stephan202
Loading

Suggested commit message:

Upgrade maven-enforcer-plugin 3.1.0 -> 3.2.1 (#487)

See:
- https://issues.apache.org/jira/issues/?jql=project%20%3D%20MENFORCER%20AND%20fixVersion%20%3E%203.1.0%20AND%20fixVersion%20%3C%3D%203.2.1%20
- https://github.com/apache/maven-enforcer/releases/tag/enforcer-3.2.1
- https://github.com/apache/maven-enforcer/compare/enforcer-3.1.0...enforcer-3.2.1

rickie
rickie approved these changes Feb 4, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a suggested commit message. Didn't dive in too deep into the new things, but curious about the following PRs 😄.

pom.xml
@@ -913,7 +918,6 @@
<version>${version.maven}</version>
</requireMavenVersion>
<requirePluginVersions />
<requireSameVersionsReactor />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds similar to the ReactorModuleConvergence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Unfortunately ReactorModuleConvergence is not compatible with -pl, so not something we can enable.

Stephan202
Stephan202 reviewed Feb 4, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked the suggested commit message :)

pom.xml
@@ -913,7 +918,6 @@
<version>${version.maven}</version>
</requireMavenVersion>
<requirePluginVersions />
<requireSameVersionsReactor />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Unfortunately ReactorModuleConvergence is not compatible with -pl, so not something we can enable.

@rickie rickie changed the title Upgrade org.apache.maven.plugins:maven-enforcer-plugin 3.1.0 -> 3.2.1 Upgrade maven-enforcer-plugin 3.1.0 -> 3.2.1 Feb 4, 2023
@rickie rickie merged commit a55ed9c into master Feb 4, 2023
@rickie rickie deleted the renovate/org.apache.maven.plugins-maven-enforcer-plugin-3.x branch February 4, 2023 09:33
@Stephan202
Copy link
Member

curious about the following PRs

I filed #489 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
dependencies
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Picnic-Bot @rickie @Stephan202