Consider avoiding the use of a pre-sized builder for the FilteredCollection and FilteredMultimapValues in Maps#uniqueIndex
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection` and `FilteredMultimapValues` in `Maps#uniqueIndex`
Stephan202
reviewed
Jul 14, 2023
Member
Stephan202
left a comment
Stephan202
left a comment
There was a problem hiding this comment.
We could offer to open this PR against the upstream repository. For completeness we should then make the equivalent change to android/guava/src/com/google/common/collect/Maps.java.
That said, the Guava maintainers generally discourage opening PRs without prior discussion, unless the change is "obvious". In this case they could also opt to revert the builderWithExpectedSize change. So what we could do instead, is refer to this PR in a comment on google#6638, and ask whether they'd accept such a PR.
oksana-evs
force-pushed
the
oksana-evs/issue-6638
branch
from
0fc1c58 to
6c47dd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR to address this issue: google#6638