Skip to content

DPLA-1351 Enforce TLS when connecting to external hosts #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: fork/v2.2.12
Choose a base branch
from
Open

DPLA-1351 Enforce TLS when connecting to external hosts #18

wants to merge 5 commits into from
+4 −4

Conversation

LucaHennart
Copy link

@LucaHennart LucaHennart commented Sep 11, 2025 •
edited
Loading

Suggested commit message:

DPLA-1351 Enforce TLS when connecting to external hosts

@LucaHennart LucaHennart changed the title DPLA-1351 Allow username configuration for external Redis-compatible databases DPLA-1351 Enforce TLS when connecting to external hosts Sep 12, 2025
@LucaHennart LucaHennart marked this pull request as ready for review September 12, 2025 09:51
nathankooij
nathankooij approved these changes Sep 12, 2025
View reviewed changes
Copy link

@nathankooij nathankooij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we should make it opt-in, but given that the ship to upstream all of this has kind of sailed, I guess we can live with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathankooij nathankooij nathankooij approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LucaHennart @nathankooij