Add missed templates folder to package #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyproject.toml
Outdated
Comment on lines
72
to
75
| [tool.poetry] | ||
| package-mode = true | ||
| packages = [ { include = "survey" } ] | ||
|
|
There was a problem hiding this comment.
I'm not using poetry, isn't that Manifest.in enough to fix the issue ?
|
Manifest file is enough for fix. I can revert poetry commit or you can
copy-paste a solution.
…On Wed, Jun 11, 2025, 11:30 Pierre Sassoulas ***@***.***> wrote:
***@***.**** commented on this pull request.
Thank you for catching this and for the PR !
------------------------------
In pyproject.toml
<#194 (comment)>
:
> +[tool.poetry]
+package-mode = true
+packages = [ { include = "survey" } ]
+
I'm not using poetry, isn't that Manifest.in enough to fix the issue ?
—
Reply to this email directly, view it on GitHub
<#194 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHG67H2SUMNDCM542LSOWD3C7SJPAVCNFSM6AAAAAB7B2GCTCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMJWGE2TMNJRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Pierre-Sassoulas
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks.
I found some wierd with package on PyPi. Wheel and tar.gz files on PyPi don't contain
templatesfolder.This PR fix this thing.