Skip to content

Remove unused dependencies from package #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

axsapronov
Copy link

Hi folks.

I am trying to use this package and sometimes find some outdated things. One of this - unused dependencies.

This PR removes:

  • django-bootstrap-form - because I didn't find usage (package uses styles from static folder) and this package doesn't work in python 3.13.
  • ordererdict - since Python 3.7, default dict save order of elements and we don't need to use custom packages
  • django-registration and django-tastypie - not found any usage

Copy link
Owner

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the import in the template enough for those kind of packageto be used ?

@axsapronov
Copy link
Author

Isn't the import in the template enough for those kind of packageto be used ?

Explicit is better than implicit (c) Python Dzen.

Import is not enough, we need use filter/simple tags in specific place for running functions. Bootstrap forms has some filters, but current template doesn't use them. Correct way for using template filters/tags - package django-crispy-forms:

{% load crispy_forms_tags %}

<form method="post" class="my-class">
    {{ my_formset|crispy }}
</form>

Copy link
Owner

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you mind fixing the git history so we can rebase ? (fixup the pre-commit autofix). Also if you're interested I"ll add you to the repo so you can merge and release.

@Pierre-Sassoulas Pierre-Sassoulas added the enhancement This is a feature not a bug label Jun 17, 2025
@Pierre-Sassoulas Pierre-Sassoulas added this to the 1.4.11 milestone Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature not a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants