-
-
Notifications
You must be signed in to change notification settings - Fork 146
Remove unused dependencies from package #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Note: since Python 3.7, default dict save order of elements
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the import in the template enough for those kind of packageto be used ?
Explicit is better than implicit (c) Python Dzen. Import is not enough, we need use filter/simple tags in specific place for running functions. Bootstrap forms has some filters, but current template doesn't use them. Correct way for using template filters/tags - package django-crispy-forms:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do you mind fixing the git history so we can rebase ? (fixup the pre-commit autofix). Also if you're interested I"ll add you to the repo so you can merge and release.
Hi folks.
I am trying to use this package and sometimes find some outdated things. One of this - unused dependencies.
This PR removes: