Move cleanup code

[cloneofghosts]

Describe the change

Small PR to move the hourly cleanup function to before it gets included in the response to hopefully remove fields from showing when they shouldn't properly this time.

Type of change

• Bugfixes to existing code
• Breaking change
• New API Version
• General Improvement
• Code quality improvements to existing code or addition of tests
• Documentation Updates

Checklist

• This pull request fixes issue: fixes #
• Code builds locally. Your pull request won't be merged unless tests pass
• Code has been formatted using ruff
• The TimeMachine version (in API/timemachine.py) matches the API version number

[gemini-code-assist]

Summary of Changes

Hello @cloneofghosts, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily resolves a bug related to data consistency in the API responses. By moving the hourly data cleanup process to an earlier stage in the PW_Forecast function, it guarantees that specific fields are properly excluded from the hourly forecast data based on the requested API version and Time Machine parameters, preventing their erroneous inclusion in the final output. Additionally, the API version has been incremented.

Highlights

• Data Cleanup Timing: I've relocated the hourly data cleanup logic within API/responseLocal.py to execute earlier in the PW_Forecast function. This ensures that fields like smoke, precipProbability, precipIntensityError, humidity, and visibility are correctly removed based on API version and Time Machine request parameters before the hourList is finalized and included in the response, addressing a bug where these fields might have incorrectly appeared.
• API Version Update: The API version string has been updated from V2.7.5b to V2.7.5c in both API/responseLocal.py and API/timemachine.py, reflecting this bugfix release.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request moves a block of code responsible for cleaning up hourly forecast data. The change aims to fix a bug where fields were not being removed correctly by performing the cleanup just before the data is added to the response object. The logic of the moved code is sound, and the version numbers in responseLocal.py and timemachine.py have been consistently updated. My review includes a suggestion to improve maintainability by defining a hardcoded list of fields as a constant, in line with the project's style guide. The style guide element referenced in the review comments is: Constants should be named using uppercase with underscores.