Support reading large USDA files #3934
Open
+7
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing failures when reading usda files great than INT_MAX on macos because the handling of larger buffers was implementation defined. The implementation here should resolve the issue instead and be more portable, allowing reads of much larger files. Thanks to Nate Reid for the patch.
Collaborator
|
Filed as internal issue #USD-11755 (This is an automated message. See here for more information.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
We were seeing failures when reading usda files great than INT_MAX on macos because the handling of larger buffers was implementation defined. The implementation here should resolve the issue instead and be more portable, allowing reads of much larger files.
This shouldn't cause any performance regressions since pread on linux also caps out at INT_MAX, but just handles the capping internally to itself.
Thanks to Nate Reid for the patch.
Fixes Issue(s)
#3582
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)