feat(sentry): add stage with sentry_sdk[flask] to dockerfile
#500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentCauchois
added
the
dependencies
jacquesfize
requested changes
May 27, 2024
There was a problem hiding this comment.
Pour moi, sentry est optionnel donc il n'a pas sa place dans le requirement général... Une solution est de faire un flag sentry dans le setup.py. Il y a un exemple dans celui de GeoNature : https://github.com/PnX-SI/GeoNature/blob/a8b5e79e3dadc3cba656b90fed60b39f87c97605/setup.py#L33C1-L41C22
VincentCauchois
force-pushed
the
feat/add-sentry-sdk-flask-library
branch
3 times, most recently
from
1f7fafa
to
9ff2670
Compare
VincentCauchois
changed the title
sentry_sdk[flask] library to requirementssentry_sdk[flask] to dockerfile
VincentCauchois
force-pushed
the
feat/add-sentry-sdk-flask-library
branch
from
9ff2670
to
0231e48
Compare
VincentCauchois
added
enhancement
and removed
dependencies
Allow to use the command `pip install -e .['sentry']` to add the `sentry-sdk` library for Flask.
VincentCauchois
force-pushed
the
feat/add-sentry-sdk-flask-library
branch
from
7657829
to
669a141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
The Python library
sentry_sdk[flask]can be used to add a connection between the Flask application and a Sentry project by adding relevant lines in theconfig.pyfile.See this docs for more information : https://docs.sentry.io/platforms/python/integrations/flask/#install