Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db downgrade does not work with data #280

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

joelclems
Copy link
Collaborator

fix #279

@joelclems joelclems force-pushed the fix/db-downgrade-with-data branch 2 times, most recently from 03cbc5e to b08ab1d Compare December 8, 2023 15:16
@amandine-sahl amandine-sahl force-pushed the dev-suivi-eolien branch 2 times, most recently from bd4a8c0 to 4b2c4d5 Compare December 8, 2023 16:48
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5db5a0c) 71.81% compared to head (77ee882) 71.36%.
Report is 3 commits behind head on dev-suivi-eolien.

Files Patch % Lines
backend/gn_module_monitoring/utils/routes.py 78.57% 3 Missing ⚠️
backend/gn_module_monitoring/monitoring/objects.py 33.33% 2 Missing ⚠️
backend/gn_module_monitoring/monitoring/queries.py 0.00% 1 Missing ⚠️
backend/gn_module_monitoring/routes/site.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           dev-suivi-eolien     #280      +/-   ##
====================================================
- Coverage             71.81%   71.36%   -0.45%     
====================================================
  Files                    31       31              
  Lines                  2228     2214      -14     
====================================================
- Hits                   1600     1580      -20     
- Misses                  628      634       +6     
Flag Coverage Δ
pytest 71.36% <73.07%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amandine-sahl amandine-sahl merged commit c2ea908 into dev-suivi-eolien Jan 19, 2024
5 of 7 checks passed
@amandine-sahl amandine-sahl deleted the fix/db-downgrade-with-data branch January 19, 2024 15:37
amandine-sahl added a commit that referenced this pull request Oct 4, 2024
Remove export as csv test

Fix/migrations (#285)

* Move create cor_type_site bib_type_site cor_module_type to geonature

* Remove id_nomenclature_type_site and migrate model to GeoNature

* Move t_observations to GeoNature

* Rename cor_type_site to cor_site_type

* Bump GeoNature

db downgrade does not work with data (#280)

Fix test export route (#293)

fix: organism_actors attributes

fix: clean python files imports + BLACK 24 (#290)

* fix: remove relative imports and unused libs

* fix: remove unused modules

* Add import fixture monitoring_users

* Reorder imports

* Black

---------

Co-authored-by: Mathieu ROUDAUT <[email protected]>
Co-authored-by: amandine-sahl <[email protected]>

fix: use table models migrated in geonature core BibTypesSites (#292)

* fix: use table models migrated in geonature core

* fix: imports in tests files

* Import TNomenclature from pypnnomenclature

---------

Co-authored-by: Mathieu ROUDAUT <[email protected]>
Co-authored-by: amandine-sahl <[email protected]>

Fix/clean transfert permissions ALL TO MONTORING_XXX (#291)

* Script sql de migration des permissions

* Changelog

Fix : sqlalchemy query

Fix/detail site url - cf #298 (#299)

* Correction url lien vers détail site

* Harmonisation popup carto

Fix/synchro on synthese (#288)

* remove silented errors when insert in synthese

* add migration for trigger delete in synthese
---------

Co-authored-by: amandine-sahl <[email protected]>

Feat/multiple geom type (#296)

* allow multiple geom type

* Sites avec plusieurs type de géométrie par défaut

---------

Co-authored-by: amandine-sahl <[email protected]>

Correction affichage propriétés spécifiques - cf #303 (#304)

Fix : migration modification for permissions (#305)

* Fix : migration modification for permissions

Ajout interaction carte liste (#300)

Fix downgrade declare available types sites

feat: add unit tests for generic monitoring routes and utils (#295)

* feat: add test for config route

* feat: add data_utils tests

* fix: response code for data utils route

* fix: rename test to match source file

* fix: remove useless file

* fix: remove legacy code

* feat: add tests for utils and error

Harmonisation des processus d'exécution de sql (#308)

* Harmonisation des processus d'exécution de sql

* Add test forbidden sql instructions

fix: filter ,sort and page on datatable (#310)

* fix: filter ,sort and page on datatable

Missing changes to check according to event on table(sort, filter, page)
Refact code for ngOnChanges

Reviewed-by: andriac

* style(front): apply prettier

Reviewed-by: andriacap
amandine-sahl added a commit that referenced this pull request Oct 4, 2024
feat: manage geom through protocol

- Fix bug changeActiveTab
- Add displaying conditional site group geometry through protocol

Reviewed-by: andriacap

fix: create site group without geom

Reviewed-by: andriacap

hotfix: remove import AppConfig

Error when using docker build

Reviewed-by: andriacap

Resolve conflicts

Use load_default for marshmallow schema - cf #268

 add id_digititer to generic observation.json  - cf #274

fix migrations downgrade - cf #269

create site with type without custom properties - cf #266

Correction frontend

[frontend] Style margin and map height - cf #270

fix site not visible in visit (#272)

fix error on site create from module (#275)

fix site property not displayed (#277)

lint prettier 3.1.0 (#278)

Remove laizy joined

Correction yml

Correction fixture sites

Add asset type de site (#282)

* Add asset type de site

Lint prettier (#281)

* Lint prettier 3.1.0

add dev-suivi-eolien in pytest.yml

[SqlAlchemy 1.4] compat sqlalchemy 1.4

Corrections + Ajout de  tests

Remove export as csv test

Fix/migrations (#285)

* Move create cor_type_site bib_type_site cor_module_type to geonature

* Remove id_nomenclature_type_site and migrate model to GeoNature

* Move t_observations to GeoNature

* Rename cor_type_site to cor_site_type

* Bump GeoNature

db downgrade does not work with data (#280)

Fix test export route (#293)

fix: organism_actors attributes

fix: clean python files imports + BLACK 24 (#290)

* fix: remove relative imports and unused libs

* fix: remove unused modules

* Add import fixture monitoring_users

* Reorder imports

* Black

---------

Co-authored-by: Mathieu ROUDAUT <[email protected]>
Co-authored-by: amandine-sahl <[email protected]>

fix: use table models migrated in geonature core BibTypesSites (#292)

* fix: use table models migrated in geonature core

* fix: imports in tests files

* Import TNomenclature from pypnnomenclature

---------

Co-authored-by: Mathieu ROUDAUT <[email protected]>
Co-authored-by: amandine-sahl <[email protected]>

Fix/clean transfert permissions ALL TO MONTORING_XXX (#291)

* Script sql de migration des permissions

* Changelog

Fix : sqlalchemy query

Fix/detail site url - cf #298 (#299)

* Correction url lien vers détail site

* Harmonisation popup carto

Fix/synchro on synthese (#288)

* remove silented errors when insert in synthese

* add migration for trigger delete in synthese
---------

Co-authored-by: amandine-sahl <[email protected]>

Feat/multiple geom type (#296)

* allow multiple geom type

* Sites avec plusieurs type de géométrie par défaut

---------

Co-authored-by: amandine-sahl <[email protected]>

Correction affichage propriétés spécifiques - cf #303 (#304)

Fix : migration modification for permissions (#305)

* Fix : migration modification for permissions

Ajout interaction carte liste (#300)

Fix downgrade declare available types sites

feat: add unit tests for generic monitoring routes and utils (#295)

* feat: add test for config route

* feat: add data_utils tests

* fix: response code for data utils route

* fix: rename test to match source file

* fix: remove useless file

* fix: remove legacy code

* feat: add tests for utils and error

Harmonisation des processus d'exécution de sql (#308)

* Harmonisation des processus d'exécution de sql

* Add test forbidden sql instructions

fix: filter ,sort and page on datatable (#310)

* fix: filter ,sort and page on datatable

Missing changes to check according to event on table(sort, filter, page)
Refact code for ngOnChanges

Reviewed-by: andriac

* style(front): apply prettier

Reviewed-by: andriacap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants