Skip to content

fix(collections-api): Remove pagerduty from tf for collections-api. #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

cass-moz
Copy link
Contributor

Goal

Clean up PagerDuty from collections-api's Terraform.

References

JIRA ticket:

Copy link

github-actions bot commented Sep 26, 2024

Plan Result (collection-api-cdk-production)

CI link

⚠️ Resource Deletion will happen

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 0 to add, 3 to change, 10 to destroy.
  • Update
    • aws_cloudwatch_metric_alarm.application_alarm-httptarget5xxerrorrate_F94D87C0
    • aws_cloudwatch_metric_alarm.synthetics_synthetics_synthetic_check_alarm_query_0_52F9FF21
    • aws_cloudwatch_metric_alarm.synthetics_synthetics_synthetic_check_alarm_uptime_0_3A56DFC7
  • Delete
    • aws_sns_topic.pagerduty_alarm-critical-topic_F1534579
    • aws_sns_topic.pagerduty_alarm-non-critical-topic_53C1A3B3
    • aws_sns_topic_subscription.pagerduty_alarm-critical-subscription_E2168B84
    • aws_sns_topic_subscription.pagerduty_alarm-non-critical-subscription_4702677B
    • pagerduty_service.pagerduty_pagerduty-critical_464EE7CD
    • pagerduty_service.pagerduty_pagerduty-non-critical_B4CB3938
    • pagerduty_service_integration.pagerduty_pagerduty_cloudwatch_7956692A-critical_546FC7B5
    • pagerduty_service_integration.pagerduty_pagerduty_cloudwatch_7956692A-non-critical_EFA67B2C
    • pagerduty_service_integration.pagerduty_pagerduty_sentry_FFB12B7C-critical_45BF6D23
    • pagerduty_service_integration.pagerduty_pagerduty_sentry_FFB12B7C-non-critical_B7B95197
Change Result (Click me)
  # aws_cloudwatch_metric_alarm.application_alarm-httptarget5xxerrorrate_F94D87C0 will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "application_alarm-httptarget5xxerrorrate_F94D87C0" {
      ~ alarm_actions             = [
          - "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical",
        ]
        id                        = "CollectionAPI-Prod-Alarm-HTTPTarget5xxErrorRate"
      ~ ok_actions                = [
          - "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical",
        ]
        tags                      = {
            "app_code"       = "pocket"
            "component_code" = "pocket-collectionapi"
            "env_code"       = "prod"
            "environment"    = "Prod"
            "service"        = "CollectionAPI"
        }
        # (13 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

  # aws_cloudwatch_metric_alarm.synthetics_synthetics_synthetic_check_alarm_query_0_52F9FF21 will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "synthetics_synthetics_synthetic_check_alarm_query_0_52F9FF21" {
      ~ alarm_actions             = [
          - "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical",
          + "",
        ]
        id                        = "colapi-prod-query-0"
      ~ ok_actions                = [
          - "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical",
          + "",
        ]
        tags                      = {}
        # (16 unchanged attributes hidden)
    }

  # aws_cloudwatch_metric_alarm.synthetics_synthetics_synthetic_check_alarm_uptime_0_3A56DFC7 will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "synthetics_synthetics_synthetic_check_alarm_uptime_0_3A56DFC7" {
      ~ alarm_actions             = [
          - "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical",
          + "",
        ]
        id                        = "colapi-prod-uptime-0"
      ~ ok_actions                = [
          - "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical",
          + "",
        ]
        tags                      = {}
        # (16 unchanged attributes hidden)
    }

  # aws_sns_topic.pagerduty_alarm-critical-topic_F1534579 will be destroyed
  # (because aws_sns_topic.pagerduty_alarm-critical-topic_F1534579 is not in configuration)
  - resource "aws_sns_topic" "pagerduty_alarm-critical-topic_F1534579" {
      - application_success_feedback_sample_rate = 0 -> null
      - arn                                      = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Critical" -> null
      - content_based_deduplication              = false -> null
      - fifo_topic                               = false -> null
      - firehose_success_feedback_sample_rate    = 0 -> null
      - http_success_feedback_sample_rate        = 0 -> null
      - id                                       = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Critical" -> null
      - lambda_success_feedback_sample_rate      = 0 -> null
      - name                                     = "CollectionAPI-Prod-Infrastructure-Alarm-Critical" -> null
      - owner                                    = "996905175585" -> null
      - policy                                   = jsonencode(
            {
              - Id        = "__default_policy_ID"
              - Statement = [
                  - {
                      - Action    = [
                          - "SNS:GetTopicAttributes",
                          - "SNS:SetTopicAttributes",
                          - "SNS:AddPermission",
                          - "SNS:RemovePermission",
                          - "SNS:DeleteTopic",
                          - "SNS:Subscribe",
                          - "SNS:ListSubscriptionsByTopic",
                          - "SNS:Publish",
                          - "SNS:Receive",
                        ]
                      - Condition = {
                          - StringEquals = {
                              - "AWS:SourceOwner" = "996905175585"
                            }
                        }
                      - Effect    = "Allow"
                      - Principal = {
                          - AWS = "*"
                        }
                      - Resource  = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Critical"
                      - Sid       = "__default_statement_ID"
                    },
                ]
              - Version   = "2008-10-17"
            }
        ) -> null
      - signature_version                        = 0 -> null
      - sqs_success_feedback_sample_rate         = 0 -> null
      - tags                                     = {} -> null
      - tags_all                                 = {
          - "app_code"       = "pocket"
          - "component_code" = "pocket-collectionapi"
          - "env_code"       = "prod"
          - "environment"    = "Prod"
          - "service"        = "CollectionAPI"
        } -> null
    }

  # aws_sns_topic.pagerduty_alarm-non-critical-topic_53C1A3B3 will be destroyed
  # (because aws_sns_topic.pagerduty_alarm-non-critical-topic_53C1A3B3 is not in configuration)
  - resource "aws_sns_topic" "pagerduty_alarm-non-critical-topic_53C1A3B3" {
      - application_success_feedback_sample_rate = 0 -> null
      - arn                                      = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical" -> null
      - content_based_deduplication              = false -> null
      - fifo_topic                               = false -> null
      - firehose_success_feedback_sample_rate    = 0 -> null
      - http_success_feedback_sample_rate        = 0 -> null
      - id                                       = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical" -> null
      - lambda_success_feedback_sample_rate      = 0 -> null
      - name                                     = "CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical" -> null
      - owner                                    = "996905175585" -> null
      - policy                                   = jsonencode(
            {
              - Id        = "__default_policy_ID"
              - Statement = [
                  - {
                      - Action    = [
                          - "SNS:GetTopicAttributes",
                          - "SNS:SetTopicAttributes",
                          - "SNS:AddPermission",
                          - "SNS:RemovePermission",
                          - "SNS:DeleteTopic",
                          - "SNS:Subscribe",
                          - "SNS:ListSubscriptionsByTopic",
                          - "SNS:Publish",
                          - "SNS:Receive",
                        ]
                      - Condition = {
                          - StringEquals = {
                              - "AWS:SourceOwner" = "996905175585"
                            }
                        }
                      - Effect    = "Allow"
                      - Principal = {
                          - AWS = "*"
                        }
                      - Resource  = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical"
                      - Sid       = "__default_statement_ID"
                    },
                ]
              - Version   = "2008-10-17"
            }
        ) -> null
      - signature_version                        = 0 -> null
      - sqs_success_feedback_sample_rate         = 0 -> null
      - tags                                     = {} -> null
      - tags_all                                 = {
          - "app_code"       = "pocket"
          - "component_code" = "pocket-collectionapi"
          - "env_code"       = "prod"
          - "environment"    = "Prod"
          - "service"        = "CollectionAPI"
        } -> null
    }

  # aws_sns_topic_subscription.pagerduty_alarm-critical-subscription_E2168B84 will be destroyed
  # (because aws_sns_topic_subscription.pagerduty_alarm-critical-subscription_E2168B84 is not in configuration)
  - resource "aws_sns_topic_subscription" "pagerduty_alarm-critical-subscription_E2168B84" {
      - arn                             = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Critical:d6252f22-4196-4887-ba23-5d4606526101" -> null
      - confirmation_timeout_in_minutes = 2 -> null
      - confirmation_was_authenticated  = false -> null
      - endpoint                        = "https://events.pagerduty.com/integration/02cb13bba9814003d03b1ba0dfa0b62d/enqueue" -> null
      - endpoint_auto_confirms          = true -> null
      - id                              = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Critical:d6252f22-4196-4887-ba23-5d4606526101" -> null
      - owner_id                        = "996905175585" -> null
      - pending_confirmation            = false -> null
      - protocol                        = "https" -> null
      - raw_message_delivery            = false -> null
      - topic_arn                       = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Critical" -> null
    }

  # aws_sns_topic_subscription.pagerduty_alarm-non-critical-subscription_4702677B will be destroyed
  # (because aws_sns_topic_subscription.pagerduty_alarm-non-critical-subscription_4702677B is not in configuration)
  - resource "aws_sns_topic_subscription" "pagerduty_alarm-non-critical-subscription_4702677B" {
      - arn                             = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical:7499cd2c-3d93-4b4a-9721-149d68888707" -> null
      - confirmation_timeout_in_minutes = 2 -> null
      - confirmation_was_authenticated  = false -> null
      - endpoint                        = "https://events.pagerduty.com/integration/6bf8c2bcb8334603d0d18633b8f7a2d2/enqueue" -> null
      - endpoint_auto_confirms          = true -> null
      - id                              = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical:7499cd2c-3d93-4b4a-9721-149d68888707" -> null
      - owner_id                        = "996905175585" -> null
      - pending_confirmation            = false -> null
      - protocol                        = "https" -> null
      - raw_message_delivery            = false -> null
      - topic_arn                       = "arn:aws:sns:us-east-1:996905175585:CollectionAPI-Prod-Infrastructure-Alarm-Non-Critical" -> null
    }

  # pagerduty_service.pagerduty_pagerduty-critical_464EE7CD will be destroyed
  # (because pagerduty_service.pagerduty_pagerduty-critical_464EE7CD is not in configuration)
  - resource "pagerduty_service" "pagerduty_pagerduty-critical_464EE7CD" {
      - acknowledgement_timeout = "1800" -> null
      - alert_creation          = "create_alerts_and_incidents" -> null
      - alert_grouping_timeout  = "null" -> null
      - auto_resolve_timeout    = "14400" -> null
      - created_at              = "2023-08-10T09:21:13-07:00" -> null
      - description             = "PagerDuty Critical" -> null
      - escalation_policy       = "PXOQVEP" -> null
      - html_url                = "https://mozilla.pagerduty.com/service-directory/PYE23V6" -> null
      - id                      = "PYE23V6" -> null
      - name                    = "CollectionAPI-Prod-PagerDuty-Critical" -> null
      - status                  = "active" -> null
      - type                    = "service" -> null

      - alert_grouping_parameters {
        }

      - incident_urgency_rule {
          - type    = "constant" -> null
          - urgency = "high" -> null
        }
    }

  # pagerduty_service.pagerduty_pagerduty-non-critical_B4CB3938 will be destroyed
  # (because pagerduty_service.pagerduty_pagerduty-non-critical_B4CB3938 is not in configuration)
  - resource "pagerduty_service" "pagerduty_pagerduty-non-critical_B4CB3938" {
      - acknowledgement_timeout = "1800" -> null
      - alert_creation          = "create_alerts_and_incidents" -> null
      - alert_grouping_timeout  = "null" -> null
      - auto_resolve_timeout    = "14400" -> null
      - created_at              = "2023-08-10T09:21:13-07:00" -> null
      - description             = "PagerDuty Non-Critical" -> null
      - escalation_policy       = "PXOQVEP" -> null
      - html_url                = "https://mozilla.pagerduty.com/service-directory/PV4E2FG" -> null
      - id                      = "PV4E2FG" -> null
      - last_incident_timestamp = "2024-01-11T12:42:06-08:00" -> null
      - name                    = "CollectionAPI-Prod-PagerDuty-Non-Critical" -> null
      - status                  = "active" -> null
      - type                    = "service" -> null

      - alert_grouping_parameters {
        }

      - incident_urgency_rule {
          - type    = "constant" -> null
          - urgency = "low" -> null
        }
    }

  # pagerduty_service_integration.pagerduty_pagerduty_cloudwatch_7956692A-critical_546FC7B5 will be destroyed
  # (because pagerduty_service_integration.pagerduty_pagerduty_cloudwatch_7956692A-critical_546FC7B5 is not in configuration)
  - resource "pagerduty_service_integration" "pagerduty_pagerduty_cloudwatch_7956692A-critical_546FC7B5" {
      - html_url        = "https://mozilla.pagerduty.com/services/PYE23V6/integrations/PCS8USJ" -> null
      - id              = "PCS8USJ" -> null
      - integration_key = "02cb13bba9814003d03b1ba0dfa0b62d" -> null
      - name            = "Amazon CloudWatch" -> null
      - service         = "PYE23V6" -> null
      - type            = "event_transformer_api_inbound_integration" -> null
      - vendor          = "PZQ6AUS" -> null
    }

  # pagerduty_service_integration.pagerduty_pagerduty_cloudwatch_7956692A-non-critical_EFA67B2C will be destroyed
  # (because pagerduty_service_integration.pagerduty_pagerduty_cloudwatch_7956692A-non-critical_EFA67B2C is not in configuration)
  - resource "pagerduty_service_integration" "pagerduty_pagerduty_cloudwatch_7956692A-non-critical_EFA67B2C" {
      - html_url        = "https://mozilla.pagerduty.com/services/PV4E2FG/integrations/PJAHVHZ" -> null
      - id              = "PJAHVHZ" -> null
      - integration_key = "6bf8c2bcb8334603d0d18633b8f7a2d2" -> null
      - name            = "Amazon CloudWatch" -> null
      - service         = "PV4E2FG" -> null
      - type            = "event_transformer_api_inbound_integration" -> null
      - vendor          = "PZQ6AUS" -> null
    }

  # pagerduty_service_integration.pagerduty_pagerduty_sentry_FFB12B7C-critical_45BF6D23 will be destroyed
  # (because pagerduty_service_integration.pagerduty_pagerduty_sentry_FFB12B7C-critical_45BF6D23 is not in configuration)
  - resource "pagerduty_service_integration" "pagerduty_pagerduty_sentry_FFB12B7C-critical_45BF6D23" {
      - html_url        = "https://mozilla.pagerduty.com/services/PYE23V6/integrations/PYFKTDW" -> null
      - id              = "PYFKTDW" -> null
      - integration_key = "1ff74c9f99304b0dc09dd8d2c72b343c" -> null
      - name            = "Sentry" -> null
      - service         = "PYE23V6" -> null
      - type            = "app_event_transform_inbound_integration" -> null
      - vendor          = "PKAPG94" -> null
    }

  # pagerduty_service_integration.pagerduty_pagerduty_sentry_FFB12B7C-non-critical_B7B95197 will be destroyed
  # (because pagerduty_service_integration.pagerduty_pagerduty_sentry_FFB12B7C-non-critical_B7B95197 is not in configuration)
  - resource "pagerduty_service_integration" "pagerduty_pagerduty_sentry_FFB12B7C-non-critical_B7B95197" {
      - html_url        = "https://mozilla.pagerduty.com/services/PV4E2FG/integrations/PG1WV59" -> null
      - id              = "PG1WV59" -> null
      - integration_key = "a0f9bcc565874508c048175f79a98200" -> null
      - name            = "Sentry" -> null
      - service         = "PV4E2FG" -> null
      - type            = "app_event_transform_inbound_integration" -> null
      - vendor          = "PKAPG94" -> null
    }

Plan: 0 to add, 3 to change, 10 to destroy.

@cass-moz cass-moz closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant