fix(linting): fix local npm lint scripts (#1207)

- also run lint-fix and add the fixed files
Pocket · Jun 20, 2024 · 066cf41 · 066cf41
1 parent 0e39129
commit 066cf41
Show file tree

Hide file tree

Showing 80 changed files with 419 additions and 408 deletions.
diff --git a/package.json b/package.json
@@ -97,8 +97,8 @@
     "build": "DISABLE_ESLINT_PLUGIN=true node scripts/build.js",
     "test": "node scripts/test.js --transformIgnorePatterns \"node_modules/(?!@apollo/client/link/core/ApolloLink.js)/\"",
     "test:nowatch": "node scripts/test.js --watchAll=false  --transformIgnorePatterns \"node_modules/(?!@apollo/client/link/core/ApolloLink.js)/\"",
-    "lint-check": "tsc --noEmit && eslint src/**/*.ts{,x}",
-    "lint-fix": "tsc --noEmit && eslint src/**/*.ts{,x} --fix",
+    "lint-check": "eslint src/**/*.ts{,x}",
+    "lint-fix": "eslint src/**/*.ts{,x} --fix",
     "api:generate-types": "graphql-codegen --config src/config/admin-api-codegen.json -r dotenv/config"
   },
   "jest": {

diff --git a/src/_shared/components/Button/Button.test.tsx b/src/_shared/components/Button/Button.test.tsx
@@ -15,7 +15,7 @@ describe('The Button component', () => {
     render(
       <Button buttonType="neutral" size="large">
         Snooze
-      </Button>
+      </Button>,
     );
 
     const button = screen.getByRole('button');

diff --git a/src/_shared/components/CardActionButtonRow/CardActionButtonRow.test.tsx b/src/_shared/components/CardActionButtonRow/CardActionButtonRow.test.tsx
@@ -20,7 +20,7 @@ describe('The CardActionButtonRow component', () => {
         onReschedule={onReschedule}
         onMoveToBottom={onMoveToBottom}
         onReject={onReject}
-      />
+      />,
     );
 
     // assert edit button is present and calls its callback

diff --git a/src/_shared/components/CorpusItemCardImage/CorpusItemCardImage.test.tsx b/src/_shared/components/CorpusItemCardImage/CorpusItemCardImage.test.tsx
@@ -21,7 +21,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate={currentScheduledDate}
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByText('Health & Fitness')).toBeInTheDocument();
@@ -46,7 +46,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate={currentScheduledDate}
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByText(/time sensitive/i)).toBeInTheDocument();
@@ -65,7 +65,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate={currentScheduledDate}
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByText(/collection/i)).toBeInTheDocument();
@@ -81,7 +81,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate={currentScheduledDate}
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByText(/syndicated/i)).toBeInTheDocument();
@@ -113,7 +113,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate={currentScheduledDate}
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByText(/last scheduled 2 days ago/i)).toBeInTheDocument();
@@ -146,7 +146,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate="2024-05-25"
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByTestId('last-scheduled-overlay')).toHaveStyle({
@@ -180,7 +180,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate="2024-05-25"
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByTestId('last-scheduled-overlay')).toHaveStyle({
@@ -214,7 +214,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate="2024-05-25"
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByTestId('last-scheduled-overlay')).toHaveStyle({
@@ -248,7 +248,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate="2024-05-25"
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByTestId('last-scheduled-overlay')).toHaveStyle({
@@ -282,7 +282,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate="2024-05-25"
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByTestId('last-scheduled-overlay')).toHaveStyle({
@@ -303,7 +303,7 @@ describe('The CorpusItemCardImage component', () => {
         currentScheduledDate={currentScheduledDate}
         scheduledSurfaceGuid="NEW_TAB_EN_US"
         toggleScheduleHistoryModal={toggleScheduleHistoryModal}
-      />
+      />,
     );
 
     expect(screen.getByText(/NEW DOMAIN/i)).toBeVisible();

diff --git a/src/_shared/components/HandleApiResponse/HandleApiResponse.test.tsx b/src/_shared/components/HandleApiResponse/HandleApiResponse.test.tsx
@@ -11,7 +11,7 @@ describe('The HandleApiResponse component', () => {
         loading={true}
         loadingText="Loading data, please wait..."
         error={undefined}
-      />
+      />,
     );
 
     expect(screen.getByText(/^loading data/i)).toBeInTheDocument();
@@ -27,7 +27,7 @@ describe('The HandleApiResponse component', () => {
             networkError: new Error('Server not found.'),
           })
         }
-      />
+      />,
     );
 
     // error messages
@@ -37,7 +37,7 @@ describe('The HandleApiResponse component', () => {
 
   it('renders nothing if the API call is successful', () => {
     const { container } = render(
-      <HandleApiResponse loading={false} error={undefined} />
+      <HandleApiResponse loading={false} error={undefined} />,
     );
 
     expect(container).toBeEmptyDOMElement();

diff --git a/src/_shared/components/Header/Header.test.tsx b/src/_shared/components/Header/Header.test.tsx
@@ -38,7 +38,7 @@ describe('The Header component', () => {
             productName="Collections"
           />
         </ThemeProvider>
-      </MemoryRouter>
+      </MemoryRouter>,
     );
 
     // There are two logos: one for desktop, one for mobile
@@ -66,7 +66,7 @@ describe('The Header component', () => {
             productName="Collections"
           />
         </ThemeProvider>
-      </MemoryRouter>
+      </MemoryRouter>,
     );
 
     // Menu links are actual links and not buttons in MUI 5, hooray!

diff --git a/src/_shared/components/LoadMore/LoadMore.test.tsx b/src/_shared/components/LoadMore/LoadMore.test.tsx
@@ -20,7 +20,7 @@ describe('The LoadMore component', () => {
         buttonDisabled={buttonDisabled}
         loadMore={loadMore}
         showSpinner={showSpinner}
-      />
+      />,
     );
 
     expect(screen.getByText(/load more results/i)).toBeInTheDocument();
@@ -34,7 +34,7 @@ describe('The LoadMore component', () => {
         buttonDisabled={buttonDisabled}
         loadMore={loadMore}
         showSpinner={showSpinner}
-      />
+      />,
     );
 
     const button = screen.getByRole('button') as HTMLButtonElement;
@@ -52,7 +52,7 @@ describe('The LoadMore component', () => {
         buttonDisabled={buttonDisabled}
         loadMore={loadMore}
         showSpinner={showSpinner}
-      />
+      />,
     );
     expect(screen.getByRole('progressbar')).toBeInTheDocument();
   });
@@ -63,7 +63,7 @@ describe('The LoadMore component', () => {
         buttonDisabled={buttonDisabled}
         loadMore={loadMore}
         showSpinner={showSpinner}
-      />
+      />,
     );
 
     const button = screen.getByRole('button') as HTMLButtonElement;

diff --git a/src/_shared/components/MarkdownPreview/MarkdownPreview.test.tsx b/src/_shared/components/MarkdownPreview/MarkdownPreview.test.tsx
@@ -24,7 +24,7 @@ describe('The MarkdownPreview component', () => {
     render(
       <MarkdownPreview minHeight={10} source={markdownSource}>
         <textarea value={markdownSource} onChange={jest.fn()} />
-      </MarkdownPreview>
+      </MarkdownPreview>,
     );
 
     // Let's check if we can see the tabs
@@ -39,7 +39,7 @@ describe('The MarkdownPreview component', () => {
     render(
       <MarkdownPreview minHeight={10} source={markdownSource}>
         <textarea value={markdownSource} onChange={jest.fn()} />
-      </MarkdownPreview>
+      </MarkdownPreview>,
     );
 
     userEvent.click(screen.getByText(/preview/i));

diff --git a/src/_shared/components/Modal/Modal.test.tsx b/src/_shared/components/Modal/Modal.test.tsx
@@ -7,7 +7,7 @@ describe('The Modal component', () => {
     render(
       <Modal open={true} handleClose={jest.fn()}>
         Loading...
-      </Modal>
+      </Modal>,
     );
     const modal = screen.getByText(/^Loading...$/i);
 

diff --git a/src/_shared/components/ScrollToTop/ScrollToTop.test.tsx b/src/_shared/components/ScrollToTop/ScrollToTop.test.tsx
@@ -13,7 +13,7 @@ describe('The ScrollToTop component', () => {
     render(
       <Router history={history}>
         <ScrollToTop />
-      </Router>
+      </Router>,
     );
 
     // move to another page

diff --git a/src/_shared/components/Tab/Tab.test.tsx b/src/_shared/components/Tab/Tab.test.tsx
@@ -14,7 +14,7 @@ describe('The Tab component', () => {
           to="/en-US/live"
           hasLink={true}
         />
-      </MemoryRouter>
+      </MemoryRouter>,
     );
 
     const tab = screen.getByRole('tab');

diff --git a/src/_shared/components/TabLink/TabLink.test.tsx b/src/_shared/components/TabLink/TabLink.test.tsx
@@ -10,7 +10,7 @@ describe('The TabLink component', () => {
         <TabLink isCurrentTab={false} to="/any/path/">
           Tab title
         </TabLink>
-      </MemoryRouter>
+      </MemoryRouter>,
     );
 
     const tabLink = screen.getByRole('link');
@@ -25,7 +25,7 @@ describe('The TabLink component', () => {
         <TabLink count={22} isCurrentTab to="/any/path/">
           Tab title
         </TabLink>
-      </MemoryRouter>
+      </MemoryRouter>,
     );
 
     const tabLink = screen.getByRole('link');
@@ -38,7 +38,7 @@ describe('The TabLink component', () => {
         <TabLink count={1235} isCurrentTab to="/any/path/">
           Tab title
         </TabLink>
-      </MemoryRouter>
+      </MemoryRouter>,
     );
 
     const tabLink = screen.getByRole('link');

diff --git a/src/_shared/components/TabNavigation/TabNavigation.test.tsx b/src/_shared/components/TabNavigation/TabNavigation.test.tsx
@@ -18,7 +18,7 @@ describe('The TabNavigation component', () => {
             to="/de-DE/scheduled/"
           />
         </TabNavigation>
-      </MemoryRouter>
+      </MemoryRouter>,
     );
     const tabNavigation = screen.getByRole('tablist');
     const tabs = within(tabNavigation).getAllByRole('tab');
@@ -49,7 +49,7 @@ describe('The TabNavigation component', () => {
           />
           <Tab label="Scheduled" count={333} value={activeTab} to={activeTab} />
         </TabNavigation>
-      </MemoryRouter>
+      </MemoryRouter>,
     );
 
     const tabNavigation = screen.getByRole('tablist');

diff --git a/src/_shared/components/TabPanel/TabPanel.test.tsx b/src/_shared/components/TabPanel/TabPanel.test.tsx
@@ -9,7 +9,7 @@ describe('The TabPanel component', () => {
     render(
       <TabPanel heading="Test tab" value="test-tab" index="test-tab">
         <p>Tab contents</p>
-      </TabPanel>
+      </TabPanel>,
     );
 
     const tabPanel = screen.getByRole('tabpanel');

diff --git a/src/_shared/components/TabSet/TabSet.test.tsx b/src/_shared/components/TabSet/TabSet.test.tsx
@@ -20,7 +20,7 @@ describe('The TabSet component', () => {
           handleChange={jest.fn()}
           tabs={tabs}
         />
-      </MemoryRouter>
+      </MemoryRouter>,
     );
 
     const tab = screen.getByRole('tab');

diff --git a/src/_shared/components/_form-elements/FormikSelectField/FormikSelectField.test.tsx b/src/_shared/components/_form-elements/FormikSelectField/FormikSelectField.test.tsx
@@ -35,7 +35,7 @@ describe('The FormikSelectField component', () => {
         <option value="2">Option 2</option>
         <option value="3">Option 3</option>
         <option value="4">Option 4</option>
-      </FormikSelectField>
+      </FormikSelectField>,
     );
 
     const field = screen.getByRole('combobox') as HTMLInputElement;
@@ -54,7 +54,7 @@ describe('The FormikSelectField component', () => {
         <option value="2">Option 2</option>
         <option value="3">Option 3</option>
         <option value="4">Option 4</option>
-      </FormikSelectField>
+      </FormikSelectField>,
     );
 
     const field = screen.getByRole('combobox') as HTMLSelectElement;

diff --git a/src/_shared/components/_form-elements/FormikTextField/FormikTextField.test.tsx b/src/_shared/components/_form-elements/FormikTextField/FormikTextField.test.tsx
@@ -30,7 +30,7 @@ describe('The FormikTextField component', () => {
         label="Test Title"
         fieldProps={fieldProps}
         fieldMeta={fieldMeta}
-      />
+      />,
     );
 
     const field = screen.getByRole('textbox') as HTMLInputElement;
@@ -44,7 +44,7 @@ describe('The FormikTextField component', () => {
         label="Test Title"
         fieldProps={fieldProps}
         fieldMeta={fieldMeta}
-      />
+      />,
     );
 
     const field = screen.getByRole('textbox') as HTMLInputElement;