feat(HNT-1363): remove parser dependency

- removes time to read (not available from zyte)
- removes publish date (ticket filed to re-add)

Author: jpetto

.gitignore

@@ -20,6 +20,7 @@
 .env.development.local
 .env.test.local
 .env.production.local
+tsconfig.tsbuildinfo
 
 npm-debug.log*
 yarn-debug.log*

src/api/fragments/BasicParserItemData.ts

@@ -1,7 +1,6 @@
 import { gql } from '@apollo/client';
 import { CuratedItemDataWithHistory } from './CuratedItemWithHistory';
 import { RejectedItemData } from './rejectedItemData';
-import { BasicParserItemData } from './BasicParserItemData';
 
 /**
  * Everything we need to fetch for a Prospect, including optional
@@ -32,11 +31,7 @@ export const ProspectDataWithCorpusItems = gql`
     rejectedCorpusItem {
       ...RejectedItemData
     }
-    item {
-      ...BasicParserItemData
-    }
   }
   ${CuratedItemDataWithHistory}
   ${RejectedItemData}
-  ${BasicParserItemData}
 `;

src/api/fragments/prospectWithCorpusItems.ts

@@ -67,7 +67,6 @@ describe('The ExistingProspectCard component', () => {
           <MemoryRouter>
             <ExistingProspectCard
               item={prospect.approvedCorpusItem!}
-              parserItem={prospect.item!}
               prospectId={prospect.prospectId}
               onSchedule={onSchedule}
               onRemoveProspect={onRemoveProspect}
@@ -100,7 +99,6 @@ describe('The ExistingProspectCard component', () => {
           <MemoryRouter>
             <ExistingProspectCard
               item={prospect.approvedCorpusItem!}
-              parserItem={prospect.item!}
               prospectId={prospect.prospectId}
               onSchedule={onSchedule}
               onRemoveProspect={onRemoveProspect}
@@ -120,7 +118,6 @@ describe('The ExistingProspectCard component', () => {
           <MemoryRouter>
             <ExistingProspectCard
               item={prospect.approvedCorpusItem!}
-              parserItem={prospect.item!}
               prospectId={prospect.prospectId}
               onSchedule={onSchedule}
               onRemoveProspect={onRemoveProspect}
@@ -140,7 +137,6 @@ describe('The ExistingProspectCard component', () => {
           <MemoryRouter>
             <ExistingProspectCard
               item={prospect.approvedCorpusItem!}
-              parserItem={prospect.item!}
               prospectId={prospect.prospectId}
               onSchedule={onSchedule}
               onRemoveProspect={onRemoveProspect}
@@ -160,7 +156,6 @@ describe('The ExistingProspectCard component', () => {
           <MemoryRouter>
             <ExistingProspectCard
               item={prospect.approvedCorpusItem!}
-              parserItem={prospect.item!}
               prospectId={prospect.prospectId}
               onSchedule={onSchedule}
               onRemoveProspect={onRemoveProspect}
@@ -183,7 +178,6 @@ describe('The ExistingProspectCard component', () => {
           <MemoryRouter>
             <ExistingProspectCard
               item={prospect.approvedCorpusItem!}
-              parserItem={prospect.item!}
               prospectId={prospect.prospectId}
               onSchedule={onSchedule}
               onRemoveProspect={onRemoveProspect}
@@ -203,7 +197,6 @@ describe('The ExistingProspectCard component', () => {
           <MemoryRouter>
             <ExistingProspectCard
               item={prospect.approvedCorpusItem!}
-              parserItem={prospect.item!}
               prospectId={prospect.prospectId}
               onSchedule={onSchedule}
               onRemoveProspect={onRemoveProspect}
@@ -252,7 +245,6 @@ describe('The ExistingProspectCard component', () => {
           <MemoryRouter>
             <ExistingProspectCard
               item={prospectWithScheduleHistory.approvedCorpusItem!}
-              parserItem={prospect.item!}
               prospectId={prospect.prospectId}
               onSchedule={onSchedule}
               onRemoveProspect={onRemoveProspect}

src/curated-corpus/components/ExistingProspectCard/ExistingProspectCard.test.tsx

@@ -20,7 +20,7 @@ import CheckCircleOutlineIcon from '@mui/icons-material/CheckCircleOutline';
 import { DateTime } from 'luxon';
 
 import { curationPalette } from '../../../theme';
-import { ApprovedCorpusItem, Item } from '../../../api/generatedTypes';
+import { ApprovedCorpusItem } from '../../../api/generatedTypes';
 import { Button } from '../../../_shared/components';
 import { getCuratorNameFromLdap } from '../../helpers/helperFunctions';
 import { ScheduleHistory } from '../ScheduleHistory/ScheduleHistory';
@@ -34,11 +34,6 @@ interface ExistingProspectCardProps {
    * An object with everything approved curated item-related in it.
    */
   item: ApprovedCorpusItem;
-
-  /**
-   * An object with details from the parser
-   */
-  parserItem: Item;
   /**
    * This is the prospect.id and NOT prospect.prospectId
    */
@@ -73,7 +68,6 @@ export const ExistingProspectCard: React.FC<ExistingProspectCardProps> = (
 ): JSX.Element => {
   const {
     item,
-    parserItem,
     onSchedule,
     onRemoveProspect,
     prospectId,
@@ -115,16 +109,6 @@ export const ExistingProspectCard: React.FC<ExistingProspectCardProps> = (
               </ListItemIcon>
               <ListItemText secondary={item.language} />
             </ListItem>
-            <ListItem disableGutters>
-              <ListItemText
-                secondary={
-                  parserItem?.datePublished &&
-                  `Published ${DateTime.fromJSDate(
-                    new Date(parserItem?.datePublished),
-                  ).toFormat('MMMM dd, yyyy')}`
-                }
-              />
-            </ListItem>
             <ListItem disableGutters>
               <ListItemIcon sx={{ minWidth: '1.5rem' }}>
                 <FaceIcon fontSize="small" />

src/curated-corpus/components/ExistingProspectCard/ExistingProspectCard.tsx

@@ -93,8 +93,6 @@ describe('The ProspectFilters component', () => {
   const onChange = jest.fn();
   const onSortByPublishedDate = jest.fn();
   const sortByPublishedDate = false;
-  const sortByTimeToRead = false;
-  const handleSortByTimeToRead = jest.fn();
 
   // const mockSetFilters = jest.fn();
   //
@@ -114,8 +112,6 @@ describe('The ProspectFilters component', () => {
         onChange={onChange}
         onSortByPublishedDate={onSortByPublishedDate}
         sortByPublishedDate={sortByPublishedDate}
-        sortByTimeToRead={sortByTimeToRead}
-        handleSortByTimeToRead={handleSortByTimeToRead}
       />,
     );
   };
@@ -142,19 +138,15 @@ describe('The ProspectFilters component', () => {
     expect(switchLabel).toBeInTheDocument();
   });
 
+  /*
+  TODO: re-enable after https://mozilla-hub.atlassian.net/browse/HNT-1364
   it('should render the sort by published date filter', () => {
     renderComponent();
 
     const publishedDate = screen.getByText(/Published Date/i);
     expect(publishedDate).toBeInTheDocument();
   });
-
-  it('should render the sort by time to read filter', () => {
-    renderComponent();
-
-    const timeToRead = screen.getByText(/Time to Read/i);
-    expect(timeToRead).toBeInTheDocument();
-  });
+  */
 
   it('should render the topic filter', () => {
     renderComponent();

src/curated-corpus/components/ProspectFilters/ProspectFilters.test.tsx

@@ -63,17 +63,6 @@ interface ProspectFiltersProps {
    * in the parent component (Prospecting page).
    */
   sortByPublishedDate: boolean;
-
-  /**
-   * Boolean flag to represent the state of sortByTimeToRead toggle in the parent component
-   * (prospecting page)
-   */
-  sortByTimeToRead: boolean;
-
-  /**
-   * Function to toggle sortByTimeToRead in the parent component (prospecting page)
-   */
-  handleSortByTimeToRead: VoidFunction;
 }
 
 /**
@@ -91,12 +80,14 @@ export const ProspectFilters: React.FC<ProspectFiltersProps> = (
     setProspectMetadataFilters,
     excludePublisherSwitch,
     filterByPublisher,
+    // remove disable after https://mozilla-hub.atlassian.net/browse/HNT-1364
+    /* eslint-disable-next-line  @typescript-eslint/no-unused-vars */
     sortByPublishedDate,
     setFilterByPublisher,
     onChange,
+    // remove disable after https://mozilla-hub.atlassian.net/browse/HNT-1364
+    /* eslint-disable-next-line  @typescript-eslint/no-unused-vars */
     onSortByPublishedDate,
-    sortByTimeToRead,
-    handleSortByTimeToRead,
   } = props;
 
   // Extract all topics from prospects item data
@@ -137,6 +128,10 @@ export const ProspectFilters: React.FC<ProspectFiltersProps> = (
           labelPlacement={'top'} // Ensures the label is on top of the switch
         />
       </FormGroup>
+      {/*
+      TODO: uncomment this filter after adding published date to prospect
+        object
+        https://mozilla-hub.atlassian.net/browse/HNT-1364
       <FormGroup>
         <FormControlLabel
           sx={{ mx: 2, mb: 2 }}
@@ -150,19 +145,7 @@ export const ProspectFilters: React.FC<ProspectFiltersProps> = (
           labelPlacement={'top'} // Ensures the label is on top of the switch
         />
       </FormGroup>
-      <FormGroup>
-        <FormControlLabel
-          sx={{ mx: 2, mb: 2 }}
-          control={
-            <Switch
-              checked={sortByTimeToRead}
-              onChange={handleSortByTimeToRead}
-            />
-          }
-          label={'Time to Read'}
-          labelPlacement={'top'} // Ensures the label is on top of the switch
-        />
-      </FormGroup>
+      */}
       {/*Topic Filter*/}
       {prospects.length > 0 && (
         <FormGroup sx={{ mx: 1, mb: 2 }}>

src/curated-corpus/components/ProspectFilters/ProspectFilters.tsx

@@ -1,35 +1,20 @@
 import React from 'react';
 import { render, screen } from '@testing-library/react';
 import { MemoryRouter } from 'react-router-dom';
-import {
-  CorpusLanguage,
-  Item,
-  Prospect,
-  Topics,
-} from '../../../api/generatedTypes';
+import { CorpusLanguage, Prospect, Topics } from '../../../api/generatedTypes';
 import { ProspectListCard } from './ProspectListCard';
 import userEvent from '@testing-library/user-event';
 import { MockedProvider, MockedResponse } from '@apollo/client/testing';
 
 describe('The ProspectListCard component', () => {
   let prospect: Prospect;
-  let parserItem: Item;
 
   const onAddToCorpus = jest.fn();
   const onRecommend = jest.fn();
   const onReject = jest.fn();
   const onRemoveProspect = jest.fn();
 
   beforeEach(() => {
-    parserItem = {
-      id: '0',
-      itemId: 'test-id',
-      givenUrl: 'www.test-item.com',
-      normalUrl: 'www.test-normal-item.com',
-      readerSlug: 'test-slug',
-      timeToRead: 5,
-    };
-
     prospect = {
       id: '123-abc',
       prospectId: '456-dfg',
@@ -46,9 +31,6 @@ describe('The ProspectListCard component', () => {
       topic: Topics.Technology,
       saveCount: 111222,
       isSyndicated: false,
-      item: {
-        ...parserItem,
-      },
     };
   });
 
@@ -62,7 +44,6 @@ describe('The ProspectListCard component', () => {
             onRecommend={onRecommend}
             onReject={onReject}
             onRemoveProspect={onRemoveProspect}
-            parserItem={prospect.item!}
           />
         </MemoryRouter>
       </MockedProvider>,
@@ -142,46 +123,6 @@ describe('The ProspectListCard component', () => {
     expect(screen.getByText('Syndicated')).toBeInTheDocument();
   });
 
-  it('should render time to read when prospect has a time to read', () => {
-    renderComponent();
-
-    expect(
-      screen.getByText(`${prospect.item?.timeToRead} min(s)`),
-    ).toBeInTheDocument();
-  });
-
-  it('should not render time to read when prospect does not a time to read', () => {
-    // setting time to read to undefined
-    parserItem.timeToRead = undefined;
-
-    // modifying prospect item to not have a time to read
-    prospect = {
-      ...prospect,
-      item: {
-        ...parserItem,
-      },
-    };
-
-    renderComponent();
-
-    expect(
-      screen.queryByText(`${prospect.item?.timeToRead} min(s)`),
-    ).not.toBeInTheDocument();
-  });
-
-  it('should render when prospect does not have a parser object', () => {
-    prospect = {
-      ...prospect,
-      item: null,
-    };
-
-    renderComponent();
-
-    expect(
-      screen.queryByText(`${prospect.item?.timeToRead} min(s)`),
-    ).not.toBeInTheDocument();
-  });
-
   it('should render prospect card with the action buttons', () => {
     renderComponent();