Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scheduling): MC-1273, MC-1274 Add 'ML-Scheduled' to filters and scheduled item card #1208

Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat(scheduling): MC-1273, MC-1274 Add 'ML-Scheduled' to filters and scheduled item card #1208

merged 2 commits into from
Jul 10, 2024

Conversation

nina-py
Copy link
Contributor

@nina-py nina-py commented Jul 9, 2024 •
edited
Loading

Goal

  • Add a new filter ("ML-Syndicated") to the "Types" filter dropdown. This is where ML-scheduled syndicated stories are now grouped to, separate to other ML stories.
  • Tweak card labels to show "ML-Syndicated" with a magic wand icon where ML-scheduled stories are syndicated, and keep the "ML" tag for other ML-scheduled items.
  • Add/update tests for new functionality.

Screenshots

Note: demo is up on Dev.

ml-syndicated filter

Reference

Tickets:

mmiermans
mmiermans approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@mmiermans mmiermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

jpetto
jpetto approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@jpetto jpetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@jpetto jpetto marked this pull request as ready for review July 10, 2024 15:53
@jpetto jpetto requested a review from a team as a code owner July 10, 2024 15:53
@jpetto jpetto merged commit 38234af into main Jul 10, 2024
10 checks passed
@jpetto jpetto deleted the MC-1273 branch July 10, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmiermans mmiermans mmiermans approved these changes

@jpetto jpetto jpetto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nina-py @jpetto @mmiermans