feat: add grade buttons to scheduled item cards#1209
Closed
Conversation
jpetto
commented
Jul 9, 2024
| undefined, | ||
| refetch, | ||
| ); | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
is this a good place to define this function?
the next PR for this will be to add the grade field to the item edit modal on all pages - which makes me think this function should be abstracted at a higher level, but i don't see an existing pattern for such a thing.
Contributor
There was a problem hiding this comment.
I think if you look at the existing pattern & function above this, moveItemToBottom, you can leave it here
Contributor
There was a problem hiding this comment.
I think it's fine. This component is where a big chunk of SchedulePage was moved out to. The plan is to split it further into testable components some time in the future 🤔
jpetto
force-pushed
the
MC-1156-add-grades-to-schedule-view
branch
from
ec9376a to
a7c59b0
Compare
Collaborator
Author
|
closing as we are not implementing grades |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
add grade buttons to scheduled item cards.
Todos
Reference
Tickets: