chore(packages): [MC-1308] Upgrade notistack library to v2 #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded the `notistack` library to v.2.0.8 - Removed one last remaining dependency on Material UI 4 that was left over in our own code
nina-py
commented
Jul 12, 2024
Comment on lines
-11
to
-14
| link: { | ||
| color: theme.palette.primary.main, | ||
| textDecoration: 'none', | ||
| }, |
There was a problem hiding this comment.
This style wasn't needed in the duplicate item modal - I think an earlier version of it had a link to the corpus item page, but it has since been replaced with a button. The rest of the styles have been moved over to the component itself into sx props.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Upgrade this library so that we no longer have an indirect dependency on Material UI v4 which has not been in active development since 2021.
notistacklibrary to v.2.0.8Reference
https://mozilla-hub.atlassian.net/browse/MC-1308