-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(topics): Add new 'Home' topic as an option in the tool #1212
Conversation
expect(topics).to.be.an('array').with.lengthOf(16); | ||
expect(topics).to.be.an('array').with.lengthOf(17); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With most of the test updates involving updating the number of topics expected, should tests be modified to not check for the total number of topics? Should we compare them to the enums in the generated code instead?
Or is adding a topic going to be a rare enough event that it's fine to leave this - and by extension the process of adding a topic - as-is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question and i'm not sure we know the answer yet re: how often will we get new topics. but - i think your point about avoiding testing a specific number of topics is sound. we should stop testing the number - i think testing against the enum sounds good.
expect(topics).to.be.an('array').with.lengthOf(16); | ||
expect(topics).to.be.an('array').with.lengthOf(17); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question and i'm not sure we know the answer yet re: how often will we get new topics. but - i think your point about avoiding testing a specific number of topics is sound. we should stop testing the number - i think testing against the enum sounds good.
DO NOT DEPLOY
See notes in https://mozilla-hub.atlassian.net/browse/MC-1248 for when this feature is going to production.
Goal
Allow the curators to categorise stories as belonging to the brand new "Home" category.
Implementation details
main
earlier than this PR is deployed, in which case the changes will be removed from this PR.Tested manually:
Reference
https://mozilla-hub.atlassian.net/browse/MC-1251