MC-1583:"Fix Title” for English titles not capitalizing first word after single quote or colon #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… after single quote or colon
jpetto
requested changes
Nov 4, 2024
Collaborator
jpetto
left a comment
jpetto
left a comment
There was a problem hiding this comment.
functionally this looks great - hoping we can add some comments and targeted unit tests 😄
jpetto
reviewed
Nov 4, 2024
| // Boolean here acts as a callback, evaluates each word: | ||
| // If it's a non-empty string, keep the word in the array; | ||
| // If it's an empty string (or falsy), remove from array. | ||
| const allWords = value.split(SEPARATORS).filter(Boolean); // Split and filter empty strings |
Collaborator
There was a problem hiding this comment.
just out of curiosity, what is the filter(Boolean) guarding against?
Contributor
Author
There was a problem hiding this comment.
filter(Boolean) removes any false values like NaN, undefined, etc
Collaborator
There was a problem hiding this comment.
but could those values ever appear in a split string? doesn't hurt to have it in, just wondering if you came across a case where something falsy ended up in the array. 😅
jpetto
approved these changes
Nov 5, 2024
Collaborator
jpetto
left a comment
jpetto
left a comment
There was a problem hiding this comment.
great work, and love the comments and tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix the capitalization rules for english titles:
'the day'->'The Day''the day' day'S->'The Day' Day'sthe day' day's: day->'The Day' Day's: DayFinal result:
Amorim aims to 'prove something' at Manchester United after agreeing deal: read the day's 'news'->Amorim Aims to ‘Prove Something’ at Manchester United After Agreeing Deal: Read the Day’s ‘News’Todos
Reference
Tickets: