Skip to content

Conversation

@jwalterss
Copy link
Contributor

Goal

Insert purpose of pull request

Todos

  • Outstanding todo
  • Completed todo

Modifying Environment Variables

Omit this section if not applicable.

  • Variables added to SSM
  • Variables added to terraform environment config

Have you followed the guidelines in our Contributing document?

Deployment

Omit this section if not applicable.

Anything we should know about deploying this PR?

Reference

Documentation here:

  • Link to docs

Tickets:

  • Link to JIRA tickets

Implementation Decisions

Implement edit custom section functionality:
- Add EditCustomSectionModal with validation for required metadata
- Call updateCustomSection mutation to persist changes
- Navigate back to custom section details page after editing
- Prevent selecting past dates for start and end dates
- Allow start and end dates to be the same day
- Ensure end date is not before start date

Implement section item management:
- Add ability to manually add items to sections from custom section details page
- Add ability to add items to sections from corpus page via schedule form
- Call createSectionItem mutation when adding items
- Support adding both existing and new corpus items
- Filter out expired sections from section dropdown
- Add status labels (Scheduled/Live) to sections in dropdown

Implement section deletion:
- Add delete section functionality with confirmation modal
- Call deleteCustomSection mutation for soft delete
- Replace window.confirm with DeleteConfirmationModal component
- Update tests to work with modal-based confirmation

Additional improvements:
- Replace hardcoded hex colors with curationPalette references
- Add border, lightRed, and veryLightGrey to theme palette
- Extract onSave handler into separate method for readability
- Remove incorrect default values (topic: 'TECHNOLOGY') from form transformations
- Use empty string defaults for controlled inputs to prevent React warnings
- Fix prettier formatting throughout
@jwalterss jwalterss requested a review from a team as a code owner October 6, 2025 17:54
@jwalterss jwalterss closed this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants