Skip to content

fix: use standardized removal modal for custom sections #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpetto merged 2 commits into from
Oct 28, 2025
Merged

fix: use standardized removal modal for custom sections #1261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6546a8
fix: use standardized removal modal for custom sections
jwalterss Oct 28, 2025
2915016
Merge branch 'main' into HNT-1126-reuse-remove-section-item-modal
jwalterss Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 23 additions & 26 deletions src/curated-corpus/components/CustomSectionDetails/CustomSectionDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, { useState } from 'react';
import { useParams, useHistory } from 'react-router-dom';
import { FormikHelpers, FormikValues } from 'formik';
import {
Box,
Typography,
Expand All @@ -23,8 +24,6 @@ import {
SectionStatus,
CreateSectionItemInput,
CreateApprovedCorpusItemInput,
RemoveSectionItemInput,
SectionItemRemovalReason,
useGetSectionsWithSectionItemsQuery,
useCreateSectionItemMutation,
useCreateApprovedCorpusItemMutation,
Expand All @@ -43,7 +42,7 @@ import {
DuplicateProspectModal,
EditCustomSectionModal,
DeleteConfirmationModal,
RemoveItemConfirmationModal,
RemoveSectionItemModal,
} from '..';
import { HandleApiResponse } from '../../../_shared/components';
import { useToggle, useRunMutation } from '../../../_shared/hooks';
Expand Down Expand Up @@ -686,43 +685,41 @@ export const CustomSectionDetails: React.FC<CustomSectionDetailsProps> = ({
}}
/>

{/* Remove Item Confirmation Modal */}
<RemoveItemConfirmationModal
open={removeItemModalOpen}
onClose={() => {
toggleRemoveItemModal();
setItemToRemove(undefined);
}}
onConfirm={async () => {
if (itemToRemove) {
// TODO(HNT-1126): Align this removal flow with the ML section modal so editors
// can pick from the standardized removal reasons instead of defaulting to Other.
const input: RemoveSectionItemInput = {
externalId: itemToRemove.externalId,
deactivateReasons: [SectionItemRemovalReason.Other],
};

await runMutation(
{/* Remove Item Modal - reuses the same modal as ML sections */}
{itemToRemove && (
<RemoveSectionItemModal
itemTitle={itemToRemove.approvedItem.title}
isOpen={removeItemModalOpen}
onSave={(values: FormikValues, formikHelpers: FormikHelpers<any>) => {
// Run the mutation with the selected removal reasons from the form
runMutation(
removeItemMutation,
{
variables: {
data: input,
data: {
externalId: itemToRemove.externalId,
deactivateReasons: values.removalReasons,
},
},
},
'Item removed from section successfully',
() => {
toggleRemoveItemModal();
setItemToRemove(undefined);
formikHelpers.setSubmitting(false);
refetch();
},
() => {
toggleRemoveItemModal();
formikHelpers.setSubmitting(false);
},
);
}
}}
itemTitle={itemToRemove?.approvedItem?.title}
/>
}}
toggleModal={() => {
toggleRemoveItemModal();
setItemToRemove(undefined);
}}
/>
)}
</Box>
);
};