Skip to content

fix: make subtitle optional for custom sections #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmiermans merged 2 commits into from
Nov 5, 2025
Merged

fix: make subtitle optional for custom sections #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48883f9
fix: make subtitle optional for custom sections
jwalterss Oct 28, 2025
a2ad5a1
Merge branch 'main' into HNT-1140-remove-subtitle-requirement
mmiermans Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/curated-corpus/components/CustomSectionForm/CustomSectionForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@ export const CustomSectionForm: React.FC<CustomSectionFormProps> = ({
<Field
as={TextField}
name="subtitle"
label="Subtitle"
required
label="Subtitle (Optional)"
fullWidth
multiline
rows={2}
Expand Down
5 changes: 0 additions & 5 deletions src/curated-corpus/components/CustomSectionForm/CustomSectionForm.validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export const getValidationSchema = (isEditMode: boolean = false) => {
subtitle: yup
.string()
.trim()
.required('Subtitle is required')
.max(500, 'Subtitle cannot exceed 500 characters'),

heroTitle: yup
Expand Down Expand Up @@ -95,10 +94,6 @@ export const validateForm = (
errors.title = 'Title is required';
}

if (!formData.subtitle.trim()) {
errors.subtitle = 'Subtitle is required';
}

if (!formData.startDate) {
errors.startDate = 'Start date is required';
} else if (formData.startDate < today) {
Expand Down
5 changes: 2 additions & 3 deletions src/curated-corpus/components/EditCustomSectionModal/EditCustomSectionModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,8 @@ describe('EditCustomSectionModal', () => {
</MockedProvider>,
);

// Check if form text labels are rendered (from CustomSectionFormConnector)
expect(screen.getByText('Title')).toBeInTheDocument();
expect(screen.getByText('Subtitle')).toBeInTheDocument();
// Check if form is rendered - looking for start date label
expect(screen.getByText('Start Date')).toBeInTheDocument();
});

it('should populate form with section data', () => {
Expand Down