Skip to content

Conversation

@mmiermans
Copy link
Contributor

@mmiermans mmiermans commented Dec 9, 2025

Goal

HNT-1345 Insert purpose of pull request

QA

The following checks were done on http://localhost:3000/ against the development environment:

image

Scheduler page

  • Single button shows for www.{domain}.com item; indicating www. is ignored.
  • For an abcnews.go.com article, two buttons are displayed (for abcnews.go.com and go.com)
  • Changing the publisher, clicking 'Save for abcnews.go.com' shows the success banner:

    Publisher 'ABC News' saved for abcnews.go.com. Future items from this domain will use this publisher.

  • After the abcnews.go.com Publisher name is saved, adding a new ABC News item shows the new name in the Publisher text box.
  • Changing the publisher, clicking 'Save for go.com' shows the success banner:

    Publisher 'Walt Disney' saved for go.com. Future items from this domain will use this publisher.

  • After saving the go.com publisher name, adding a new disneyworld.disney.go.com shows the saved publisher name.
  • Adding an article with a Punycode domain allows the publisher with special characters to be set (Törn).

Custom sections

  • Saving and pre-populating publisher names works in the ApprovedItem dialog in Custom Sections.

ML sections

  • Save button shows up on the ApprovedItem dialog in ML sections

ML sections

  • Save button shows up on the ApprovedItem dialog in ML sections

Deployment

  • This change will be left in the development environment for a day on Dec 10th, to let editors play with it and familiarize themselves with the new functionality.

  • A message will be posted in the #hnt-editorial channel notifying the editorial team of the change:

    In the development curation admin tools you can now preview an upcoming change that lets you edit publisher names directly from the Edit Item dialog. We plan to bring this to production on Thursday morning. Feel free to play around in the development curation admin tools; any changes you make there will not go to users.

    How it will work:

    • In the Edit Item dialog you will see a button “Save for {domain}” next to the Publisher field. Change the Publisher to the correct name and click this button. All future items from that domain will use this publisher name, across all locales and all ingestion methods (including ML). This does not affect existing items. You still need to click Save to apply changes to the item you are editing.

    • For items with a subdomain, you will also see “Save for {subdomain}” next to the Publisher field (see screenshot below). This works the same way, but applies only to future items from that subdomain. If names are saved for both a domain and a subdomain, the subdomain takes precedence. For example, you can set es.euronews.comEuronews Español, and euronews.comEuronews.

    image
Screencast.from.2025-12-09.18-59-19.webm

Reference

@mmiermans mmiermans changed the title HNT- HNT-1345: Allow curators to update publisher names Dec 9, 2025
// The most basic of integration tests - we simply send through
// the corpus item without any actual edits.
userEvent.click(screen.getByText(/save/i));
userEvent.click(screen.getByText(/^save$/i));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was necessary because there are now multiple buttons containing 'save' in the text.

@mmiermans mmiermans marked this pull request as ready for review December 10, 2025 03:37
@mmiermans mmiermans requested a review from a team as a code owner December 10, 2025 03:37
jpetto
jpetto previously approved these changes Dec 10, 2025
Copy link
Collaborator

@jpetto jpetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mmiermans mmiermans merged commit c5f79c4 into main Dec 11, 2025
6 checks passed
@mmiermans mmiermans deleted the curated-corpus branch December 11, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants