fix(HNT-1379): fix saving prospects with datePublished value #1265
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensures datePublished value is converted to YYYY-MM-DD value prior to form submission (required by graph input)
jpetto
commented
Dec 12, 2025
| </Grid> | ||
| <Box display="none"> | ||
| <TextField | ||
| type="hidden" |
Collaborator
Author
There was a problem hiding this comment.
removed this as it was preventing the tests from finding the fields. display="none" on the wrapping element keeps them out of view.
mmiermans
approved these changes
Dec 12, 2025
| ? DateTime.fromJSDate(new Date(approvedItem.datePublished)).toFormat( | ||
| 'yyyy-MM-dd', | ||
| ) | ||
| : null, |
Contributor
There was a problem hiding this comment.
Hm... Does this mean approvedItem.datePublished has invalid dates sometimes? The database type is date. Or does it perhaps get formatted as 2025-12-11 00:00:00 somewhere by JS?
Collaborator
Author
There was a problem hiding this comment.
i believe the parser gave us a date value - YYYY-MM-DD - but zyte gives us YYYY-MM-DD HH:MM:SS, and the graph rejects due to the time value being there
jpetto
deleted the
HNT-1379-fix-saving-prospects-with-datePublished-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
fix saving prospects with datePublished value
tested locally against dev data.
Reference
Documentation here:
Tickets: