Skip to content

Comments

✨ bidirectional sync#5

Merged
Poeschl merged 7 commits intoPoeschl-HomeAssistant-Addons:mainfrom
MB901:feature-bidirectional-sync
Mar 3, 2025
Merged

✨ bidirectional sync#5
Poeschl merged 7 commits intoPoeschl-HomeAssistant-Addons:mainfrom
MB901:feature-bidirectional-sync

Conversation

@MB901
Copy link

@MB901 MB901 commented Jan 20, 2025

Hi, thank you for this addon!

I’ve made some improvements to enhance functionality and usability:

  • Added the ability to sync files from the remote server to Home Assistant (bidirectional sync).
  • Removed the unused remote_folder variable.
  • Updated folder naming conventions: switched from source/destination to local/remote to better reflect the purpose when using pull/push options.

Testing:

  • Verified the sync process in both directions (local-to-remote and remote-to-local).
  • Ensured that removing the remote_folder variable does not break existing configurations.

Let me know if you have any questions or need further changes.

Thanks!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['breaking-change', 'bugfix', 'documentation', 'enhancement', 'refactor', 'new-feature', 'maintenance', 'dependencies']

@MB901 MB901 changed the title Add feature: bidirectional sync new-feature: bidirectional sync Jan 20, 2025
@Poeschl Poeschl added the new-feature New features or options. label Jan 22, 2025
@Poeschl Poeschl changed the title new-feature: bidirectional sync ✨ bidirectional sync Jan 22, 2025
Copy link
Member

@Poeschl Poeschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments from my side ;)

And it seems the linter picks up the old config folder. It's optional to fix that. If its not done in your PR, I will do it before release.

@MB901 MB901 requested a review from Poeschl January 29, 2025 15:38
@Poeschl Poeschl merged commit ab6493a into Poeschl-HomeAssistant-Addons:main Mar 3, 2025
12 checks passed
@MB901 MB901 deleted the feature-bidirectional-sync branch March 4, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature New features or options.

Development

Successfully merging this pull request may close these issues.

2 participants