Dev #322
Open
Dev #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_auto_url_metadata feat(app): Add Miscellaneous URL Metadata Task
…_additional_information feat(app): Add additional information to Final Review Process
…_final_review_multiple_agency_ids Mc 173 final review multiple agency ids
Previously, agency ids not already in the database were rejected. Now these are permitted with a placeholder name
…_agency_ids feat(app): `/review/approve-source` new agencies added to db
…_validated_urls fix(database): Fix bug causing validated URLs to show up for some annotations
# Conflicts: # collector_db/enums.py # core/AsyncCore.py
…_auto_googler_erroring_frequently Set default for snippet if none exists.
…_filter_by_batch_id feat(app): Add batch filtering for annotation requests
Additionally, modify `review/approve-source` to no longer accept `relevant` key-value pair.
…_review_reject_source feat(app): add `review/reject-source` endpoint
Now, URLs marked not relevant by a user should not show up for subsequent annotations such as record type or agency.
…_hide_user_not_relevant feat(database): Adjust annotation logic for URLs marked not relevant
Previously, the `/annotate/agencies` `POST` method would return a 500 error when an agency whose ID was not yet in the DBI database was submitted. This has been resolved.
…_add_agency_ids_via_annotate_agencies feat(database): add agency not in database in annotate agencies
BREAKING CHANGE: All `/review/`endpoints now require the `source_collector_final_review` permission
# Conflicts: # core/AsyncCore.py
# Conflicts: # src/db/queries/implementations/core/get_next_url_for_final_review.py # tests/automated/integration/collector_db/test_db_client.py # tests/automated/integration/tasks/test_agency_preannotation_task.py # tests/manual/pdap_client/test_pdap_client.py
…_agencies_sync mc_315_agencies_sync
…_add_progress_bar_to_final_review mc_313_add_progress_bar_to_final_review
Extract logic to AnnotationExistsCTEQueryBuilder Begin work on GetMetricsURLSAggregatedPendingQueryBuilder
…_metrics_urls_aggregate_pending mc_312_metrics_urls_aggregate_pending
…_update_progress_bar_for_final_review mc_313_update_progress_bar_for_final_review
…_agencies_sync mc_315_agencies_sync
# Conflicts: # api/main.py
link to api tos
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 16713553 | Triggered | Generic Password | 72ed9c9 | local_database/setup_fdw.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…mocked_url_request_interface Add logic for storing compressed html when scraping HTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.