-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics to the site #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ecmcclain Sorry about my delayed response. this is looking great! I like the text and icons you chose + generally how these look. I will probably suggest some copy edits before merge, but for now:
-
your email and password are exposed in the DataView; once you get your API key (by logging in), we should be able to just use that. We will use a different key when deployed to production
- can you use the API to reset your password too? we don't want any impersonators...
-
could you add a note to the README about which
.env
variables are required for local development? (fig 1) -
For slow-loading components—we have part of the solution figured out in the design system. If you run the dev version, you can see some shimmer classes in action (fig 2). We may need to update the design system version, but I'm not sure.
There's more info about lazy loading in vue here.
Ideally the dynamic components would be as small as possible, so the header and surrounding context would be visible.
- I sent you a Donorbox API key, and their docs are here, for the donors metrics.
fig 1
fig 2
TODO: For the Airtable API: I am not sure if using the "status (depreciated)" to find completed data requests will cause issues down the line if we are no longer tracking the progress of data requests in this way? |
@ecmcclain ok, this is looking great! I know it must have been a fair amount of work to do the design system migration alone.
sorry about the change up in strategy for getting these! LMK if that makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this because I need to work on the site, and this fixes two issues! We can circle back in #183
Fixes #176
Fixes #179
/ metrics
/data metrics:
NOTE: These metrics are slow to load from the data sources API—any idea how I could make it faster?
/community metrics