Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to the site #177

Merged
merged 10 commits into from
Oct 3, 2024
Merged

Add metrics to the site #177

merged 10 commits into from
Oct 3, 2024

Conversation

ecmcclain
Copy link

@ecmcclain ecmcclain commented Jul 18, 2024

Fixes #176
Fixes #179

/ metrics
Screenshot 2024-07-18 at 3 19 39 PM

/data metrics:
Screenshot 2024-07-18 at 3 19 23 PM
NOTE: These metrics are slow to load from the data sources API—any idea how I could make it faster?

/community metrics
Screenshot 2024-07-18 at 3 21 05 PM

@ecmcclain ecmcclain linked an issue Jul 18, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

@josh-chamberlain josh-chamberlain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ecmcclain Sorry about my delayed response. this is looking great! I like the text and icons you chose + generally how these look. I will probably suggest some copy edits before merge, but for now:

  1. your email and password are exposed in the DataView; once you get your API key (by logging in), we should be able to just use that. We will use a different key when deployed to production

    • can you use the API to reset your password too? we don't want any impersonators...
  2. could you add a note to the README about which .env variables are required for local development? (fig 1)

  3. For slow-loading components—we have part of the solution figured out in the design system. If you run the dev version, you can see some shimmer classes in action (fig 2). We may need to update the design system version, but I'm not sure.

There's more info about lazy loading in vue here.

Ideally the dynamic components would be as small as possible, so the header and surrounding context would be visible.

  1. I sent you a Donorbox API key, and their docs are here, for the donors metrics.

fig 1

Screen Shot 2024-07-23 at 11 32 26 AM

fig 2

Screen Shot 2024-07-23 at 11 35 46 AM

@ecmcclain ecmcclain changed the base branch from main to vue-frontend-dev August 21, 2024 22:54
@josh-chamberlain josh-chamberlain removed the request for review from mbodeantor August 26, 2024 16:58
@josh-chamberlain josh-chamberlain changed the base branch from vue-frontend-dev to dev September 4, 2024 14:20
@ecmcclain
Copy link
Author

TODO:
-on /donate finish the DonorBox API connection

For the Airtable API: I am not sure if using the "status (depreciated)" to find completed data requests will cause issues down the line if we are no longer tracking the progress of data requests in this way?

@josh-chamberlain
Copy link
Contributor

@ecmcclain ok, this is looking great! I know it must have been a fair amount of work to do the design system migration alone.

  1. for requests, and data sources, I wonder if you could switch to using the v2 API: https://data-sources-v2.pdap.io/api
    • we have added a requests endpoint to the dev branch, but not to main yet (we can do that soon)
  2. For the Airtable API: I am not sure if using the "status (depreciated)" to find completed data requests will cause issues down the line if we are no longer tracking the progress of data requests in this way?

  3. our donorbox email is [email protected]

sorry about the change up in strategy for getting these! LMK if that makes sense.

Copy link
Contributor

@josh-chamberlain josh-chamberlain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this because I need to work on the site, and this fixes two issues! We can circle back in #183

@josh-chamberlain josh-chamberlain merged commit 1cd32ed into dev Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants