Prevent floating-point error in decile calculation #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Runner taking longer than usual so merging |
MaxGhenis
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234.
Unfortunately, the original intended implementation of just attempting to round erroneously high values in
rank()was not sufficient, so this also adds the use ofnp.minimum()to each of the -ile functions to ensure no value exceeds their intended max.I have not added tests, as I am unfamiliar with the testing protocol of this package. I am happy to do so, but am unsure how to simulate the floating point error necessary to reproduce this bug, other than adding a large dataset that actively triggers it, then testing against that. I am happy to do so, if desired.