Add conditional imports for heavier packages #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGhenis
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #236.
This adds conditional imports for
matplotlibandseabornfor the few relevant functions where they are necessary. It also adds a[charts]install option tosetup.pyto enable the install of these, and uses try/except blocks to ensure the packages are installed.This was tested locally by manually importing and running tests from
-coreand-usagainst.Following the merging of this, I intend to do the following:
-coreremoving the duplicativemicrodfcode from it and installing this version-usand-ukto upgrade to this version, as most of their code does not use-core's duplicative version ofmicrodf