optimize beacon beam rendering #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minecraft typically renders the beacon beam twice per frame. This is noticeable by comparing the opacity of the
beacon beam when the beacon is in view versus when it's out of view (fly 50 blocks above, for instance).
This fix is based off a Forge PR that was added to 1.11.x:
https://github.com/MinecraftForge/MinecraftForge/pull/3651/files
Related Issue(s)
Fixes #38
How to test
Place a beacon beam, check opacity, go up and check opacity. You can look up and down to get the beacon block in and out of view to test once you are high up
Release Notes
Documentation