Catching weird Carbon errors

Poniverse · Jan 25, 2017 · 3217062 · 3217062
1 parent 7d9eaf9
commit 3217062
Showing 1 changed file with 19 additions and 7 deletions.
diff --git a/app/Commands/ParseTrackTagsCommand.php b/app/Commands/ParseTrackTagsCommand.php
@@ -80,7 +80,7 @@ public function execute()
             $this->track->track_number = null;
         } else {
             $this->track->track_number = filter_var($this->input['track_number'] ?? $parsedTags['track_number'], FILTER_SANITIZE_NUMBER_INT);
-            if ($this->track->track_number == null) {
+            if ($this->track->track_number === null) {
                 $this->track->track_number = 1;
             }
         }
@@ -463,18 +463,30 @@ protected function parseDateString(string $dateString)
         switch (Str::length($dateString)) {
             // YYYY
             case 4:
-                return Carbon::createFromFormat('Y', $dateString)
-                    ->month(1)
-                    ->day(1);
+                try {
+                    return Carbon::createFromFormat('Y', $dateString)
+                        ->month(1)
+                        ->day(1);
+                } catch (\InvalidArgumentException $e) {
+                    return null;
+                }
 
             // YYYY-MM
             case 7:
-                return Carbon::createFromFormat('Y m', str_replace("-", " ", $dateString))
-                    ->day(1);
+                try {
+                    return Carbon::createFromFormat('Y m', str_replace("-", " ", $dateString))
+                        ->day(1);
+                } catch (\InvalidArgumentException $e) {
+                    return null;
+                }
 
             // YYYY-MM-DD
             case 10:
-                return Carbon::createFromFormat('Y m d', str_replace("-", " ", $dateString));
+                try {
+                    return Carbon::createFromFormat('Y m d', str_replace("-", " ", $dateString));
+                } catch (\InvalidArgumentException $e) {
+                    return null;
+                }
                 break;
 
             default: