fix: Fix bug where all Chinese books had same file names, also improve internal filename handling #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2025 10:58
Also disable TOC based parsing for external/imported books due to inconsitent behaviour Signed-off-by: starry-shivam <[email protected]>
…6 hex values to file names Signed-off-by: starry-shivam <[email protected]>
Signed-off-by: starry-shivam <[email protected]>
starry-shivam
added a commit
that referenced
this pull request
May 5, 2025
…e internal filename handling (#247) * Fix bug where all Chinese books had same filenames. * Improve internal filename handling to avoid duplicate filenames. * Disable TOC based parsing for external/imported books due to inconsistent behavior & often broken chapter mapping. --------- Signed-off-by: starry-shivam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While on that, also disabled TOC-based EPUB parsing due to inconsistent behavior and broken chapter mapping on multiple occasions.