-
-
Notifications
You must be signed in to change notification settings - Fork 83
Create values-fr #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create values-fr #251
Conversation
French translation. Sorry if it's not the right way, i've never used Github
starry-shivam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. It looks good overall; however, lint is failing due to a small error in the translation file, which I’ve pointed out.
PaxGooroo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it. Now i must find where upload the new file in the right place and good way ^^
Is this like this ? In this window ?
|
You can replace it just fine :) |
|
Hi, just checking — are you having any trouble making changes? If so, feel free to ask. I’ll try to fix it myself; I’d hate to let your hard work in translating all those strings go to waste. |
|
@PaxGooroo I've fixed the issues with the PR and merged your translation, thanks again for your contribution. |
* Create values-fr * Update values-fr * Fix some missing escapes * Rename values-fr to temp * add missing values folder and fix incorrect string res name * Delete app/src/main/res/temp --------- Co-authored-by: Stɑrry Shivɑm <[email protected]>
French translation.
Sorry if it's not the right way, i've never used Github
Please go the the
Previewtab and select the appropriate sub-template: