Skip to content

Conversation

@PaxGooroo
Copy link
Contributor

French translation.
Sorry if it's not the right way, i've never used Github

Please go the the Preview tab and select the appropriate sub-template:

  • General PR: for all other PRs, including bug fixes, adding features etc.
  • Translation PR: specifically to be used for translation PRs

French translation.
Sorry if it's not the right way, i've never used Github
@PaxGooroo PaxGooroo requested a review from starry-shivam as a code owner June 15, 2025 20:50
Copy link
Member

@starry-shivam starry-shivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. It looks good overall; however, lint is failing due to a small error in the translation file, which I’ve pointed out.

@PaxGooroo PaxGooroo requested a review from starry-shivam June 16, 2025 20:52
Copy link
Contributor Author

@PaxGooroo PaxGooroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it. Now i must find where upload the new file in the right place and good way ^^
Is this like this ? In this window ?

@starry-shivam
Copy link
Member

You can replace it just fine :)

@starry-shivam
Copy link
Member

Hi, just checking — are you having any trouble making changes? If so, feel free to ask. I’ll try to fix it myself; I’d hate to let your hard work in translating all those strings go to waste.

@starry-shivam starry-shivam merged commit ebe6dae into Pool-Of-Tears:main Jun 21, 2025
1 check passed
@starry-shivam
Copy link
Member

@PaxGooroo I've fixed the issues with the PR and merged your translation, thanks again for your contribution.

starry-shivam added a commit that referenced this pull request Jun 21, 2025
* Create values-fr
* Update values-fr
* Fix some missing escapes
* Rename values-fr to temp
* add missing values folder and fix incorrect string res name
* Delete app/src/main/res/temp
---------

Co-authored-by: Stɑrry Shivɑm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants