feat: update azure foundry provider#1029
Merged
VisargD merged 2 commits intoPortkey-AI:mainfrom Apr 12, 2025
Merged
Conversation
Contributor
Author
|
/matter review |
Contributor
|
I'm reviewing this PR now. I'll provide feedback shortly. |
Contributor
|
I encountered an error while trying to review this PR. Please try again later. |
narengogi
approved these changes
Apr 10, 2025
VisargD
approved these changes
Apr 12, 2025
Contributor
Author
|
Ref: #920 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author Description
(optional)
Title: feat: update azure foundry provider
🔄 What Changed
🔍 Impact of the Change
📁 Total Files Changed
🧪 Test Added
N/A - No tests were added in this PR
🔒 Security Vulnerabilities
No security vulnerabilities detected. The PR improves security by supporting more secure authentication methods.
Quality Recommendations
Add unit tests to verify the new authentication methods work correctly
Add error handling for failed token acquisition in the authentication methods
Consider adding documentation comments to explain the different authentication modes
Add validation for the azureFoundryUrl parameter to ensure it's properly formatted