Skip to content

fix: make patch package as part of main dep for docker builds & move … #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

b4s36t4
Copy link
Contributor

@b4s36t4 b4s36t4 commented Apr 14, 2025

Code Quality bug fix

Author Description

(optional)

  • Detailed change 1
  • Detailed change 2

Title:

  • fix: make patch package as part of main dep for docker builds & move patches

Description:

🔄 What Changed

  • Moved patch-package from devDependencies to dependencies in package.json
  • Added COPY commands in Dockerfile to include the patches directory in both build and runtime stages

🔍 Impact of the Change

  • Fixes Docker build failures by ensuring patches are properly included in the Docker image
  • Ensures patch-package is available at runtime to apply patches correctly

📁 Total Files Changed

  • Dockerfile: 2 additions (COPY commands for patches directory)
  • package.json: 2 additions, 2 deletions (moving patch-package to dependencies)

🧪 Test Added

N/A - Configuration changes only

🔒 Security Vulnerabilities

N/A - No security implications

Motivation:

  • Fix Docker build failures related to patches not being properly included in the build process

Related Issues:
N/A

Quality Recommendations

  1. Consider adding a comment in the Dockerfile explaining why patches need to be copied to help future maintainers understand the purpose

  2. Consider adding a postinstall script in package.json to automatically apply patches during container initialization

@VisargD VisargD merged commit 9f3d351 into Portkey-AI:main Apr 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants