Skip to content

README for sample app#10

Closed
pauldambra wants to merge 2 commits intomainfrom
chore/pd/readme
Closed

README for sample app#10
pauldambra wants to merge 2 commits intomainfrom
chore/pd/readme

Conversation

@pauldambra
Copy link
Member

it's a while since i ran asp .net so there may be a better way of telling folk to do this

but i wanted to run against local so needed to set these two settings

i'll assume some other people are as silly as me and a note in the README might help 😊

@pauldambra pauldambra requested a review from haacked as a code owner January 16, 2025 19:03
@haacked
Copy link
Collaborator

haacked commented Jan 16, 2025

There's instructions for this in the PostHog.AspNetCore README: https://github.com/PostHog/posthog-dotnet/blob/main/src/PostHog.AspNetCore/README.md

However, as I think about it, if users update appsettings.Development.json, they'll have to be careful not to commit those to this repository. So I think we should suggest the commands to run to set the env variables like I do with the ProjectApiKey.

@haacked
Copy link
Collaborator

haacked commented Jan 16, 2025

For users of this library, they can put settings in appSettings.json for their own project, but we probably don't want them to do that for our project.

@pauldambra
Copy link
Member Author

cool cool... happy for you to edit this PR or just throw it away and do something else :)

@haacked
Copy link
Collaborator

haacked commented Jan 17, 2025

I did something else. Thanks though!

@haacked haacked closed this Jan 17, 2025
@haacked haacked deleted the chore/pd/readme branch January 17, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants