feat: New IFeatureFlagCache interface and implementations #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also implement this twice, a default implementation and an implementation that caches in HttpContext.Items.
When using the `PostHogClient` in the context of an aspnetcore request, feature flags are retrieved once per HTTP request and cached for the duration of that request. Under the hood, this is implemented by storing them in `HttpContext.Items`. Fixes #11
Something that's unlikely to create a conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HttpContextFeatureFlagCacheimplementsIFeatureFlagCacheand retrieves feature flags fromHttpContext.Itemsif they exist. Otherwise it calls the/decideendpoint. Items are cached perdistinctUserId, which in most cases will map 1-1 to an HTTP request.If the
HttpContextis not available, then feature flags are always requested.By default,
PostHogClientwill use aNullFeatureFlagCachewith no caching. When registeringPostHogClientusing the methods provided for ASP.NET Core, that's replaced with anHttpContextFeatureFlagCache.Fixes #11