Skip to content

Apply some of the greptile recommendations #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 14, 2025
Merged

Conversation

haacked
Copy link
Collaborator

@haacked haacked commented Feb 13, 2025

Just a bit of code cleanup.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR focuses on improving logging infrastructure and error handling across the PostHog .NET client, with emphasis on type safety and maintainability.

  • Added centralized GeneralLoggingExtensions.cs for shared logging functionality with source-generated methods
  • Changed logger types to use strongly-typed ILogger<T> instead of generic ILogger for better type safety and context
  • Improved error handling around JSON deserialization with specific exception handling for JsonException
  • Made JsonAssert class internal to restrict visibility within assembly
  • Updated XML documentation and type safety by changing Attr from object to string? in error responses

10 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile

@haacked haacked force-pushed the haacked/greptile-cleanup branch from add9760 to d42155a Compare February 14, 2025 03:01
@haacked haacked merged commit 06b5d68 into main Feb 14, 2025
4 checks passed
@haacked haacked deleted the haacked/greptile-cleanup branch February 14, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant