-
Notifications
You must be signed in to change notification settings - Fork 7
Apply some of the greptile recommendations #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, defensively deserialize the `UnauthorizedApiResult`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR focuses on improving logging infrastructure and error handling across the PostHog .NET client, with emphasis on type safety and maintainability.
- Added centralized
GeneralLoggingExtensions.cs
for shared logging functionality with source-generated methods - Changed logger types to use strongly-typed
ILogger<T>
instead of genericILogger
for better type safety and context - Improved error handling around JSON deserialization with specific exception handling for
JsonException
- Made
JsonAssert
class internal to restrict visibility within assembly - Updated XML documentation and type safety by changing
Attr
fromobject
tostring?
in error responses
10 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
And update the READMEs.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
And not `bool?`.
add9760
to
d42155a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bit of code cleanup.