Improve configuration of the PostHog client #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a builder pattern for PostHog configuration in ASP.NET Core applications, improving service registration flexibility and configuration options.
- Added new
PostHogOptionsBuilderin/src/PostHog.AspNetCore/PostHogOptionsBuilder.csfor structured configuration - Removed
/src/PostHog.AspNetCore/Library/Ensure.csutility class - ensure null checking is handled appropriately in new implementation - Modified
/src/PostHog.AspNetCore/Registration.csto use builder pattern and returnIHostApplicationBuilderfor better method chaining - Updated version from 1.0.0-beta.8 to 1.0.0-beta.9 across configuration files
- Added internal visibility between PostHog and PostHog.AspNetCore assemblies in
/src/PostHog/Config/AssemblyInfo.cs
7 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| => UseConfigurationSection(builder.Configuration.GetSection(configurationSectionName)); | ||
|
|
||
| /// <summary> | ||
| /// Specifies the the configuration section to use for PostHog options. If this call is omitted, |
There was a problem hiding this comment.
syntax: Typo in XML comment - 'the the' is duplicated
Suggested change
| /// Specifies the the configuration section to use for PostHog options. If this call is omitted, | |
| /// Specifies the configuration section to use for PostHog options. If this call is omitted, |
| /// </summary> | ||
| /// <param name="builder">The <see cref="IHostApplicationBuilder"/>.</param> | ||
| /// <param name="configurationSection">The configuration section where to load config settings.</param> | ||
| /// <param name="options">Provides a mean to configure the <see cref="PostHogClient"/> and some of the services it uses.</param> |
There was a problem hiding this comment.
syntax: typo in XML comment: 'Provides a mean' should be 'Provides a means'
Suggested change
| /// <param name="options">Provides a mean to configure the <see cref="PostHogClient"/> and some of the services it uses.</param> | |
| /// <param name="options">Provides a means to configure the <see cref="PostHogClient"/> and some of the services it uses.</param> |
| builder.Services.AddSingleton<ITaskScheduler, TaskRunTaskScheduler>(); | ||
| builder.Services.AddSingleton<IPostHogClient, PostHogClient>(); | ||
| return builder.Services.AddHttpClient(nameof(PostHogClient)); | ||
| options = NotNull(options); |
There was a problem hiding this comment.
logic: NotNull check on options happens after builder - should check builder first since it's the primary parameter
Suggested change
| options = NotNull(options); | |
| builder = NotNull(builder); | |
| options = NotNull(options); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.