-
Notifications
You must be signed in to change notification settings - Fork 7
Prepare the 1.0.0 release #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR prepares the PostHog .NET SDK for its first stable 1.0.0 release, marking it as production-ready.
- Version updated from
1.0.0-beta.12
to1.0.0
inDirectory.Build.props
, though contains duplicateNullable
property and incorrect copyright year (2025) - Modified
PostHogClient
constructor to handle null dependencies with sensible defaults, improving flexibility - Added comprehensive XML documentation across multiple files to enhance API discoverability and usage clarity
- Changed
PropertyFilterValueJsonConverter
from public to internal sealed for better encapsulation - Fixed potential issue in
PostHogClient
wheretimeProvider
was used before null check inMemoryCache
initialization
14 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Makes for better grammar. And the enum value is determined by the attribute so it doesn't affect serialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the version to 1.0.0 (removing the beta label).
It also adds some code documentation and changes the ctor for
PostHogClient
to accept nulls for each of the dependencies and provides a simple alternative when null.