Skip to content

Prepare the 1.0.0 release #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 24, 2025
Merged

Prepare the 1.0.0 release #57

merged 8 commits into from
Feb 24, 2025

Conversation

haacked
Copy link
Collaborator

@haacked haacked commented Feb 24, 2025

This bumps the version to 1.0.0 (removing the beta label).

It also adds some code documentation and changes the ctor for PostHogClient to accept nulls for each of the dependencies and provides a simple alternative when null.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR prepares the PostHog .NET SDK for its first stable 1.0.0 release, marking it as production-ready.

  • Version updated from 1.0.0-beta.12 to 1.0.0 in Directory.Build.props, though contains duplicate Nullable property and incorrect copyright year (2025)
  • Modified PostHogClient constructor to handle null dependencies with sensible defaults, improving flexibility
  • Added comprehensive XML documentation across multiple files to enhance API discoverability and usage clarity
  • Changed PropertyFilterValueJsonConverter from public to internal sealed for better encapsulation
  • Fixed potential issue in PostHogClient where timeProvider was used before null check in MemoryCache initialization

14 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile

haacked and others added 5 commits February 24, 2025 10:16
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Makes for better grammar. And the enum value is determined by the attribute so it doesn't affect serialization.
@haacked haacked merged commit ffb0433 into main Feb 24, 2025
4 checks passed
@haacked haacked deleted the haacked/1.0 branch February 24, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant