Skip to content

chore(flags): update quota-limited logs#58

Merged
dmarticus merged 3 commits intomainfrom
chore/more-quota-limit-logs
Feb 27, 2025
Merged

chore(flags): update quota-limited logs#58
dmarticus merged 3 commits intomainfrom
chore/more-quota-limit-logs

Conversation

@dmarticus
Copy link
Contributor

see this discussion here: PostHog/posthog-js#1758 (comment)

@dmarticus dmarticus requested a review from haacked as a code owner February 25, 2025 22:45
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the logging for quota limit warnings in the PostHogClient class, making error messages more informative and actionable.

  • Added '[FEATURE FLAGS]' prefix to quota exceeded log messages for better categorization
  • Added link to billing limits documentation (https://posthog.com/docs/billing/limits-alerts) in warning messages
  • Clarified that feature flag data will be reset when quota limits are exceeded
  • Updated both overloads of LogWarningQuotaExceeded method for consistency
  • Improved error message clarity to help users understand the impact of hitting quota limits

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Collaborator

@haacked haacked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Flawless victory!

@dmarticus dmarticus merged commit 18c7e8e into main Feb 27, 2025
4 checks passed
@dmarticus dmarticus deleted the chore/more-quota-limit-logs branch February 27, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants