Fix unhandled object disposed exception #59
Merged
+181
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpContext.Items can be disposed by the time we're trying to set the cache. This is because we might be making in a background thread. In that case, we don't want to fail the operation.
Update VersionConstants.cs
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds error handling for HttpContext disposal and enhances feature flag support in the PostHog .NET client.
- Added graceful handling of
ObjectDisposedExceptioninHttpContextFeatureFlagCachewhen accessingHttpContext.Itemsfrom background threads - Added new overloads to
CapturePageViewandCaptureScreenViewmethods to support sending feature flag data - Added comprehensive test coverage for HttpContext disposal scenarios in
HttpContextFeatureFlagCacheTests - Bumped version from 1.0.1 to 1.0.2 and fixed duplicate
Nullableproperty inDirectory.Build.props
6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpContext.Items can be disposed by the time we're trying to set the cache. This is because we might be making in a background thread. In that case, we don't want to fail the operation.
Also added some overloads to
CapturePageViewandCaptureScreenthat send feature flag data.