Remove internal method from IPostHogClient interface

[haacked]

This method was there to support .NET Feature Management. For now, I'll just cast to PostHogClient and use reflection if the IPostHogClient isn't a PostHogClient. It's ugly, but it'll do for now.

I do see the benefit of a method to enumerate flag definitions on IPostHogClient, I just need to think it over a bit. Any method we add, we have to support. Do we do an IAsyncEnumerabel or a Task<IReadOnlyList> or something else?

Fixes #60

[greptile-apps]

PR Summary

This PR removes the internal GetLocalEvaluatorAsync method from IPostHogClient interface and implements a temporary reflection-based workaround to maintain .NET Feature Management functionality.

• Moved GetLocalEvaluatorAsync from interface to internal method in src/PostHog/PostHogClient.cs
• Added new src/PostHog.AspNetCore/FeatureManagement/FeatureManagementExtensions.cs with reflection-based workaround
• Introduces potential performance overhead due to reflection usage in extension method
• Author acknowledges need to carefully design proper API for flag definition enumeration (IAsyncEnumerable vs IReadOnlyList)
• Change simplifies unit testing for dependent projects by removing internal interface method

_{4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile}