Skip to content

Show whether we're using local eval or not #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

haacked
Copy link
Collaborator

@haacked haacked commented Mar 11, 2025

Update the sample to show whether local eval is being used or not.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the visibility of PostHog's feature flag evaluation mode in the sample web application by adding clear indicators for local vs. remote evaluation states.

  • Added new PersonalApiKeyIsSet property in Index.cshtml.cs to track local evaluation capability
  • Updated alert messages in Index.cshtml to explicitly show whether local or remote evaluation is being used
  • Renamed ApiKeyIsSet to ProjectApiKeyIsSet for better clarity on API key types
  • Improved error handling by separating project and personal API key validation checks

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@haacked haacked merged commit 74e6210 into main Mar 11, 2025
4 checks passed
@haacked haacked deleted the haacked/sample-improvements branch March 11, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant