feat(flags): Allow specifying flags to evaluate #67
+220
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for PostHog/posthog#29493 which allows specifying a set of flag keys to evaluate. Fixes #62
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added support for specifying a subset of feature flags to evaluate via the /decide endpoint, allowing for more efficient feature flag evaluation by only requesting specific flags instead of all flags.
- Added
FlagKeysToEvaluateproperty toAllFeatureFlagsOptionsclass, initialized with empty list for backward compatibility - Updated
GetFeatureFlagsFromDecideAsyncinPostHogApiClientto include flag keys in request payload when specified - Added predicate-based request handling in
FakeHttpMessageHandlerto support testing flag key evaluation - Added comprehensive test coverage for both local and remote flag evaluation scenarios with specific keys
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for PostHog/posthog#29493 which allows specifying a set of flag keys to evaluate.
Fixes #62