Merged
Conversation
And just debug assert that they're not "coding error" exceptions. We don't want to miss out on exception logging in our async batching that could cause the process to crash without good info.
Contributor
There was a problem hiding this comment.
PR Summary
Enhanced exception handling in AsyncBatchHandler to catch and log all unexpected exceptions while maintaining debug assertions for coding errors, along with version bump to 1.0.4.
- Added general exception handling in
src/PostHog/Library/AsyncBatchHandler.cswith Debug.Assert checks for ArgumentException and NullReferenceException - Improved logging for unexpected exceptions in HandleFlushSignal, HandleTimer, and DisposeAsync methods
- Removed duplicate Nullable property declaration in
Directory.Build.props - Updated version from 1.0.3 to 1.0.4 across configuration files
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And just debug assert that they're not "coding error" exceptions.
We don't want to miss out on exception logging in our async batching that could cause the process to crash without good info.
And bump version to 1.0.4.