Skip to content

Revert "Remove unnecessary workflow" #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

haacked
Copy link
Collaborator

@haacked haacked commented Jun 12, 2025

This reverts commit 70920f3.

@haacked haacked enabled auto-merge June 12, 2025 16:51
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Restores the call-flags-project-board.yml workflow for automated feature flag project board management in .github/workflows/. This workflow integrates with PostHog's centralized project board system for tracking feature flag implementations.

  • Re-adds workflow that triggers on PR events (open, review, sync) to update feature flag project board
  • Leverages shared workflow from PostHog/.github repository for consistent project management
  • Maintains automation for tracking feature flag development across PostHog repositories

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@haacked haacked marked this pull request as draft June 13, 2025 20:06
auto-merge was automatically disabled June 13, 2025 20:06

Pull request was converted to draft

@dmarticus dmarticus moved this to Todo in Feature Flags Jun 13, 2025
@haacked haacked marked this pull request as ready for review June 13, 2025 20:06
@haacked haacked removed this from Feature Flags Jun 13, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Re-adds call-flags-project-board.yml workflow, completing the feature flag project management setup alongside existing workflows like main.yaml and stale-labeller.yaml. This maintains consistency in PostHog's CI/CD pipeline.

  • Workflow complements existing CI setup which already includes build, test, format, and release processes
  • Fits into repository's established GitHub Actions pattern of using reusable workflows
  • Aligns with repository's automated project management approach seen in stale-labeller.yaml

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@haacked haacked marked this pull request as draft June 13, 2025 20:07
@haacked haacked marked this pull request as ready for review June 13, 2025 20:13
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Reintroduces the feature flag project board workflow file, examined in context with the repository's comprehensive CI/CD setup documented in .github/workflows/main.yaml and stale-labeller.yaml.

  • Integration extends the repository's existing automation ecosystem that includes build, test, and stale PR management
  • Workflow specifically runs on pull request lifecycle events to maintain feature flag development tracking
  • Uses established pattern of calling reusable workflows from PostHog's central .github repository

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@haacked haacked marked this pull request as draft June 13, 2025 20:13
@haacked haacked marked this pull request as ready for review June 13, 2025 20:16
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Reversion of workflow removal maintains critical cross-repository orchestration for feature flag tracking in PostHog's ecosystem.

  • Restores .github/workflows/call-flags-project-board.yml that serves as a lightweight workflow caller, keeping infrastructure code minimal
  • Ensures continued compatibility with PostHog's unified feature flag tracking system across multiple SDKs
  • Follows the repository's consistent pattern of externalizing shared workflows to reduce maintenance overhead

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@haacked haacked requested a review from a team June 13, 2025 20:20
@dmarticus dmarticus moved this to In Review in Feature Flags Jun 13, 2025
@haacked haacked marked this pull request as draft June 13, 2025 20:43
@haacked haacked marked this pull request as ready for review June 13, 2025 21:48
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Re-adds critical project board workflow file that was previously removed, completing the repository's CI/CD automation infrastructure by maintaining integration with PostHog's centralized feature flag tracking system.

  • Re-added file acts as a bridge between .NET SDK and central PostHog project management, triggered by PR lifecycle events
  • Notable for its inheritance of secrets configuration, enabling secure cross-repository workflow calls
  • Special attention to draft PR handling, with explicit draft status parameter passed to central workflow

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@haacked haacked marked this pull request as draft June 13, 2025 22:01
@dmarticus dmarticus moved this from In Review to Todo in Feature Flags Jun 13, 2025
@haacked haacked marked this pull request as ready for review June 13, 2025 22:08
@dmarticus dmarticus moved this from Todo to In Review in Feature Flags Jun 13, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Restores the call-flags-project-board.yml workflow, which works in conjunction with the repository's existing GitHub Actions infrastructure (main.yaml and stale-labeller.yaml) documented in the codebase.

  • Workflow operates alongside scheduled jobs (like stale PR checking at midnight UTC) without scheduling conflicts
  • Aligns with repository's existing permissions model which already includes PR write access for automation
  • Maintains consistency with Ubuntu-latest runner environment used by other workflows

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@haacked haacked marked this pull request as draft June 14, 2025 03:15
@dmarticus dmarticus moved this from In Review to Todo in Feature Flags Jun 14, 2025
@haacked haacked removed the request for review from a team June 14, 2025 03:16
@haacked haacked marked this pull request as ready for review June 14, 2025 03:16
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Reverts the removal of call-flags-project-board.yml workflow file, with analysis of the workflow's role in the CI/CD ecosystem.

  • Cross-repository workflow inheritance requires specific GITHUB_TOKEN permissions, a critical security detail not previously highlighted
  • File restoration fixes potential automation gaps in PR lifecycle events (opened, ready for review, synchronized)
  • Completes the unified feature flag tracking system without interfering with existing 14-day stale PR checks

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@haacked haacked removed this from Feature Flags Jun 14, 2025
@haacked haacked requested a review from a team June 16, 2025 15:53
@github-project-automation github-project-automation bot moved this to Approved in Feature Flags Jun 16, 2025
@haacked haacked merged commit fe54640 into main Jun 17, 2025
15 of 19 checks passed
@haacked haacked deleted the haacked/revert-removal-of-workflow branch June 17, 2025 16:08
@github-project-automation github-project-automation bot moved this from Approved to Done in Feature Flags Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants