extra validations when specifying custom endpoint#8
Closed
dselans wants to merge 1 commit intoPostHog:masterfrom
Closed
extra validations when specifying custom endpoint#8dselans wants to merge 1 commit intoPostHog:masterfrom
dselans wants to merge 1 commit intoPostHog:masterfrom
Conversation
Had issues posting to a self-hosted instance of posthog. Realized that this was because the library expects me to provide just the address (as in `https://host.name.com`) whereas I was providing `https://host.name.com/capture`. This PR adds some extra validations for the expected endpoint config. Sidenote: for those who have kong in front of posthog, make sure to add routes for both `/capture` and `/batch` - this library uses `/batch` :)
Contributor
|
Thanks for this, we've added the endpoint validation in the v1.5.12 as an effect of a slightly bigger refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had issues posting to a self-hosted instance of posthog. Realized that this was
because the library expects me to provide just the address (as in
https://host.name.com)whereas I was providing
https://host.name.com/capture.This PR adds some extra validations for the expected endpoint config.
Sidenote: for those who have kong in front of posthog, make sure to add routes
for both
/captureand/batch- this library uses/batch:)