feat: add recording url blocklist #1500
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @richard-better! 👋 |
|
Size Change: +11.4 kB (+0.38%) Total Size: 3.02 MB
ℹ️ View Unchanged
|
| this._checkUrlTrigger() | ||
| this._checkTriggerConditions() | ||
|
|
||
| if (this.status === 'paused' && !isRecordingPausedEvent(rawEvent)) { |
There was a problem hiding this comment.
So I've added this to make sure this one event can go through even if the recording is paused, but... it seems like onRRwebEmit never gets called with this event?
There was a problem hiding this comment.
i ran it locally and these get called for me (in tests iirc there's no real rrweb so custom events don't work - could it be that)
i got lots of paused events... don't know if it's because i had breakpoints set or if i'm getting a paused on every mutation?
| this._tryTakeFullSnapshot() | ||
|
|
||
| this._scheduleFullSnapshot() | ||
| this._tryAddCustomEvent('recording resumed', { reason: 'left blocked url' }) |
There was a problem hiding this comment.
Same deal as the paused event, this one never makes it to onRRwebEmit 🤔
@pauldambra, do you have any idea what I'm doing wrong here?
| { type: 3, data: { source: 1 } }, | ||
| { type: 3, data: { source: 2 } }, | ||
| // This should be in the buffer | ||
| // { type: 5, data: { tag: 'recording paused', payload: { reason: 'url blocker' } } }, |
There was a problem hiding this comment.
ah, yes, this'll be because mocked rrweb i bet... may well be a way we can improve the mock to pass along custom events - although feel free to not spend too much time on that
if I really care then i put tests into cypress so i'm exercising a real rrweb
|
really silly scope creep idea... we could add ph-no-capture to the body and remove it again as we hit/leave no-record pages 🤔 |
|
further scope creep... "skipping inactivity" while we're on a blocked page is the wrong player message. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Changes
Client for PostHog/posthog#25845
Enables pausing the recording when certain urls are visited.
Checklist