fix: dead click fixes from watching in prod #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pauldambra
commented
Oct 31, 2024
pauldambra
commented
Oct 31, 2024
| const absoluteTimeout = checkTimeout(click.absoluteDelayMs, this._config.mutation_threshold_ms) | ||
| // we want to timeout eventually even if nothing else catches it... | ||
| // we leave a little longer than the maximum threshold to give the other checks a chance to catch it | ||
| const absoluteTimeout = checkTimeout(click.absoluteDelayMs, this._config.mutation_threshold_ms * 1.1) |
There was a problem hiding this comment.
we saw absolute timeouts, without seeing mutation timeouts, that also seems wrong so...
pauldambra
commented
Oct 31, 2024
| $dead_click_selection_changed_delay_ms: click.selectionChangedDelayMs, | ||
| }, | ||
| { | ||
| timestamp: new Date(click.timestamp), |
There was a problem hiding this comment.
turns out this is how you set the timestamp on an event
pauldambra
commented
Oct 31, 2024
Comment on lines
+24
to
+63
| /* | ||
| * Check whether an element has nodeType Node.ELEMENT_NODE | ||
| * @param {Element} el - element to check | ||
| * @returns {boolean} whether el is of the correct nodeType | ||
| */ | ||
| export function isElementNode(el: Node | Element | undefined | null): el is Element { | ||
| return !!el && el.nodeType === 1 // Node.ELEMENT_NODE - use integer constant for browser portability | ||
| } | ||
|
|
||
| /* | ||
| * Check whether an element is of a given tag type. | ||
| * Due to potential reference discrepancies (such as the webcomponents.js polyfill), | ||
| * we want to match tagNames instead of specific references because something like | ||
| * element === document.body won't always work because element might not be a native | ||
| * element. | ||
| * @param {Element} el - element to check | ||
| * @param {string} tag - tag name (e.g., "div") | ||
| * @returns {boolean} whether el is of the given tag type | ||
| */ | ||
| export function isTag(el: Element | undefined | null, tag: string): el is HTMLElement { | ||
| return !!el && !!el.tagName && el.tagName.toLowerCase() === tag.toLowerCase() | ||
| } | ||
|
|
||
| /* | ||
| * Check whether an element has nodeType Node.TEXT_NODE | ||
| * @param {Element} el - element to check | ||
| * @returns {boolean} whether el is of the correct nodeType | ||
| */ | ||
| export function isTextNode(el: Element | undefined | null): el is HTMLElement { | ||
| return !!el && el.nodeType === 3 // Node.TEXT_NODE - use integer constant for browser portability | ||
| } | ||
|
|
||
| /* | ||
| * Check whether an element has nodeType Node.DOCUMENT_FRAGMENT_NODE | ||
| * @param {Element} el - element to check | ||
| * @returns {boolean} whether el is of the correct nodeType | ||
| */ | ||
| export function isDocumentFragment(el: Element | ParentNode | undefined | null): el is DocumentFragment { | ||
| return !!el && el.nodeType === 11 // Node.DOCUMENT_FRAGMENT_NODE - use integer constant for browser portability | ||
| } |
There was a problem hiding this comment.
moved these from auto capture code since we now have an element utils for them to live in
|
Size Change: +90 B (0%) Total Size: 3.01 MB
ℹ️ View Unchanged
|
ioannisj
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turned on dead clicks in prod
watched what we captured realised some things could be improved